Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ID allocator monotonic #3303

Closed
disksing opened this issue Dec 24, 2020 · 2 comments
Closed

Make ID allocator monotonic #3303

disksing opened this issue Dec 24, 2020 · 2 comments
Assignees
@nolouch
Labels
severity/critical type/bug The issue is confirmed as a bug. type/enhancement The issue or PR belongs to an enhancement.

Comments

@disksing
Copy link
Contributor

Feature Request

Describe your feature request related problem

Currently, the ID allocator is guaranteed not to allocate duplicated IDs, but when PD leader changes multiple times, the IDs may not be monotonic.

Describe the feature you'd like

We can sync allocator once PD becomes leader.

Describe alternatives you've considered

none.

Teachability, Documentation, Adoption, Migration Strategy

none.
@disksing disksing added the type/enhancement The issue or PR belongs to an enhancement. label Dec 24, 2020
@AstroProfundis AstroProfundis mentioned this issue Dec 24, 2020
Merged
@BusyJay
Copy link
Member

BusyJay commented Dec 25, 2020

When is the bug introduced? Or what versions are affected?

@BusyJay
Copy link
Member

BusyJay commented Dec 25, 2020

It should probably be marked as bug instead. state_id in replication mode also uses the same id allocator, which breaks the assumption that it increases at every step.

@nolouch nolouch added type/bug The issue is confirmed as a bug. severity/critical labels Dec 25, 2020
@nolouch nolouch mentioned this issue Dec 25, 2020
Merged
This was referenced Dec 28, 2020
Merged
Closed
Merged
Merged
@nolouch nolouch closed this as completed Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nolouch nolouch

Labels
severity/critical type/bug The issue is confirmed as a bug. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@BusyJay @nolouch @disksing