Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

id: fix the id allocator is not monotonic (#3305) #3309

Merged
merged 2 commits into from
Jul 1, 2021

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #3305 to release-3.0


What problem does this PR solve?

What is changed and how it works?

This PR tries to make the id monotonic since there are many components that depend on this property. ref: #3303

Check List

Tests

  • Unit test

Related changes

Release note

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/cherry-pick labels Dec 28, 2020
@ti-srebot ti-srebot added this to the v3.0.20 milestone Dec 28, 2020
@ti-chi-bot ti-chi-bot requested a review from lhy1024 December 28, 2020 06:38
@ti-srebot
Copy link
Contributor Author

@rleungx you're already a collaborator in bot's repo.

@lhy1024
Copy link
Contributor

lhy1024 commented Dec 28, 2020

plz fix

@rleungx rleungx force-pushed the release-3.0-65e08e2b7de7 branch 3 times, most recently from 3731b21 to d176af7 Compare December 29, 2020 10:31
@HunDunDM
Copy link
Member

This PR contains #3310

@HunDunDM HunDunDM modified the milestones: v3.0.20, v3.0.21 Jan 5, 2021
@rleungx rleungx force-pushed the release-3.0-65e08e2b7de7 branch 2 times, most recently from 139478a to 442d15c Compare January 25, 2021 02:40
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx rleungx force-pushed the release-3.0-65e08e2b7de7 branch from 442d15c to d6aad11 Compare January 25, 2021 02:43
@codecov
Copy link

codecov bot commented Jan 25, 2021

Codecov Report

Merging #3309 (7c5a39e) into release-3.0 (669ecba) will decrease coverage by 0.14%.
The diff coverage is 53.33%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-3.0    #3309      +/-   ##
===============================================
- Coverage        67.35%   67.20%   -0.15%     
===============================================
  Files              171      170       -1     
  Lines            14334    14315      -19     
===============================================
- Hits              9654     9621      -33     
- Misses            3740     3746       +6     
- Partials           940      948       +8     
Impacted Files Coverage Δ
server/leader.go 76.49% <33.33%> (-0.61%) ⬇️
server/id.go 72.97% <54.54%> (+1.54%) ⬆️
server/server.go 78.20% <100.00%> (+0.05%) ⬆️
pkg/etcdutil/etcdutil.go 86.11% <0.00%> (-8.34%) ⬇️
server/namespace_cluster.go 81.48% <0.00%> (-5.56%) ⬇️
server/util.go 65.67% <0.00%> (-5.23%) ⬇️
server/tso.go 74.41% <0.00%> (-4.66%) ⬇️
server/grpc_service.go 56.35% <0.00%> (-1.85%) ⬇️
client/client.go 68.94% <0.00%> (-1.42%) ⬇️
server/handler.go 45.88% <0.00%> (-0.59%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 669ecba...7c5a39e. Read the comment docs.

@rleungx
Copy link
Member

rleungx commented Jan 25, 2021

/run-all-tests

@rleungx
Copy link
Member

rleungx commented Jan 25, 2021

/run-integration-lightning-test

1 similar comment
@nolouch
Copy link
Contributor

nolouch commented Jan 27, 2021

/run-integration-lightning-test

@rleungx rleungx added type/cherry-pick-for-release-3.0 The PR belongs to release-3.0 cherry pick. and removed type/cherry-pick-for-release-1.0 labels Apr 25, 2021
@nolouch
Copy link
Contributor

nolouch commented Jun 30, 2021

/run-integration-ddl-test

@nolouch
Copy link
Contributor

nolouch commented Jul 1, 2021

contains #3322.

@nolouch nolouch merged commit 4e29c2f into tikv:release-3.0 Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/cherry-pick-not-approved status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-3.0 The PR belongs to release-3.0 cherry pick.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants