Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PD cannot satisfy 3 Voter and 1 learner rules #4140

Closed
nolouch opened this issue Sep 18, 2021 · 2 comments · Fixed by #4166
Closed

PD cannot satisfy 3 Voter and 1 learner rules #4140

nolouch opened this issue Sep 18, 2021 · 2 comments · Fixed by #4166
Assignees
Labels
severity/major status/TODO The issue will be done in the future. type/bug The issue is confirmed as a bug.

Comments

@nolouch
Copy link
Contributor

nolouch commented Sep 18, 2021

Bug Report

What did you do?

the region

peer 2 in zone2, peer 3  in zone3, peer 4 in zone3

add the rule

[]string{"1/voter/zone=zone1//", "1/voter/zone=zone2/", "1/voter/zone=zone3/", "1/learner/zone=zone4/"

What did you expect to see?

the region became 3voter + 1 learner

What did you see instead?

the operator adds peer 5 in zone1, and blocking on 4 voters.

What version of PD are you using (pd-server -V)?

master

@nolouch nolouch added the type/bug The issue is confirmed as a bug. label Sep 18, 2021
@nolouch
Copy link
Contributor Author

nolouch commented Sep 18, 2021

the reason is only 3 rules can find the fit peer, the learner rule is not satisfied. but fixOrphanPeers only works on all rules are satisfied. and there are only 4 tikv, cannot add learners and remove extra voters. we need to support demote voter to fix this situation.

@mayjiang0203
Copy link

/severity Major

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity/major status/TODO The issue will be done in the future. type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants