Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Demoting single voter directly isn't working #4444

Closed
w41ter opened this issue Dec 9, 2021 · 4 comments · Fixed by #4534
Closed

Demoting single voter directly isn't working #4444

w41ter opened this issue Dec 9, 2021 · 4 comments · Fixed by #4534
Assignees
@HunDunDM @matchge-ca
Labels
affects-5.3 affects-5.4 severity/moderate status/TODO The issue will be done in the future. type/bug The issue is confirmed as a bug.

Comments

@w41ter
Copy link
Contributor

w41ter commented Dec 9, 2021

Bug Report

Details see issue tikv/tikv#11463.

This is introduced in #4166, to fix #4140. I decide to change the field ChangePeer to ChangePeerV2 if demoting a voter directlry. This can avoid breaking compatibility.
@w41ter w41ter added the type/bug The issue is confirmed as a bug. label Dec 9, 2021
w41ter added a commit to w41ter/pd that referenced this issue Dec 9, 2021
@w41ter
server/schedule: use ChangePeerV2 to demote single voter directly
984da8a 
ref tikv#4444.
@w41ter w41ter mentioned this issue Dec 9, 2021
Closed
w41ter added a commit to w41ter/pd that referenced this issue Dec 9, 2021
@w41ter
server/schedule: use ChangePeerV2 to demote single voter directly
c21656e 
ref tikv#4444.

Signed-off-by: p4tr1ck <patricknicholas@foxmail.com>
@nolouch
Copy link
Contributor

nolouch commented Dec 13, 2021

/assign @PatrickNicholas

@mayjiang0203
Copy link

/severity moderate

@HunDunDM
Copy link
Member

HunDunDM commented Dec 15, 2021 •
edited
Loading

/cc @matchge-ca

@HunDunDM HunDunDM mentioned this issue Dec 15, 2021
Closed
@nolouch nolouch added the status/TODO The issue will be done in the future. label Dec 28, 2021
@matchge-ca matchge-ca mentioned this issue Jan 3, 2022
Merged
@matchge-ca
Copy link
Contributor

/assign

This was referenced Jan 6, 2022
Merged
Merged
@nolouch nolouch added needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. affects-5.3 affects-5.4 and removed needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. labels Jan 6, 2022
ti-chi-bot added a commit that referenced this issue Feb 21, 2022
@ti-chi-bot @matchge-ca @HunDunDM
operator: remove empty JointConsensus steps and fix single voter demo…
00a625f 
…te bug (#4534) (#4552)

ref #4362, ref #4444, ref #4534

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: HunDunDM <hundundm@gmail.com>

Co-authored-by: matchge <74505524+matchge-ca@users.noreply.github.com>
Co-authored-by: HunDunDM <hundundm@gmail.com>
@HunDunDM HunDunDM mentioned this issue Aug 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HunDunDM HunDunDM

@matchge-ca matchge-ca

Labels
affects-5.3 affects-5.4 severity/moderate status/TODO The issue will be done in the future. type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

operator: remove empty JointConsensus steps and fix single voter demote bug matchge-ca/pd
6 participants
@nolouch @w41ter @mayjiang0203 @HunDunDM @ti-chi-bot @matchge-ca