Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing voter from 2 voter replicas raft group would make region unavailable #4411

Closed
w41ter opened this issue Dec 1, 2021 · 4 comments · Fixed by #4564
Closed

Removing voter from 2 voter replicas raft group would make region unavailable #4411

w41ter opened this issue Dec 1, 2021 · 4 comments · Fixed by #4564
Labels
severity/major type/bug The issue is confirmed as a bug.

Comments

@w41ter
Copy link
Contributor

w41ter commented Dec 1, 2021

Bug Report

What did you do?

Remove a voter from 2 voter replicas. Details in tikv/tikv#10595.

What did you expect to see?

Region shouldn't be unavailable.

What did you see instead?

A region would be unavailable.

What version of PD are you using (pd-server -V)?
@w41ter w41ter added the type/bug The issue is confirmed as a bug. label Dec 1, 2021
@w41ter
Copy link
Contributor Author

w41ter commented Dec 1, 2021

This is part of work in tikv: tikv/tikv#11502

w41ter added a commit to w41ter/pd that referenced this issue Dec 1, 2021
@w41ter
server/schedule: prevent removing voters directly in 2 replica raft g…
c5a51e3 
…roup

close tikv#4411

Signed-off-by: p4tr1ck <patricknicholas@foxmail.com>
@w41ter w41ter mentioned this issue Dec 1, 2021
Closed
@mayjiang0203
Copy link

mayjiang0203 commented Dec 15, 2021 •
edited
Loading

/severity major

@ti-chi-bot
Copy link
Member

@mayjiang0203: The label(s) severity/mojor cannot be applied, because the repository doesn't have them.

In response to this:

/severity mojor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@HunDunDM
Copy link
Member

Need to solve #4444 first.

HunDunDM added a commit to HunDunDM/pd that referenced this issue Jan 12, 2022
@HunDunDM
schedule: prevent removing voters directly in 2 replica raft group
e594366 
close tikv#4411

Signed-off-by: HunDunDM <hundundm@gmail.com>
@HunDunDM HunDunDM mentioned this issue Jan 12, 2022
Merged
ti-chi-bot added a commit that referenced this issue Jan 13, 2022
@HunDunDM @ti-chi-bot
schedule: prevent removing voters directly in 2 replica raft group (#…
1279d55 
…4564)

* schedule: prevent removing voters directly in 2 replica raft group

close #4411

Signed-off-by: HunDunDM <hundundm@gmail.com>

* fix test

Signed-off-by: HunDunDM <hundundm@gmail.com>

* add test

Signed-off-by: HunDunDM <hundundm@gmail.com>

* add name

Signed-off-by: HunDunDM <hundundm@gmail.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
disksing pushed a commit to oh-my-tidb/pd that referenced this issue Feb 8, 2022
@HunDunDM @ti-chi-bot @disksing
schedule: prevent removing voters directly in 2 replica raft group (t…
5f2112f 
…ikv#4564)

* schedule: prevent removing voters directly in 2 replica raft group

close tikv#4411

Signed-off-by: HunDunDM <hundundm@gmail.com>

* fix test

Signed-off-by: HunDunDM <hundundm@gmail.com>

* add test

Signed-off-by: HunDunDM <hundundm@gmail.com>

* add name

Signed-off-by: HunDunDM <hundundm@gmail.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
4 participants
@w41ter @mayjiang0203 @HunDunDM @ti-chi-bot