Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable more linters #4322

Open
rleungx opened this issue Nov 11, 2021 · 0 comments
Open

Enable more linters #4322

rleungx opened this issue Nov 11, 2021 · 0 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/enhancement The issue or PR belongs to an enhancement.

Comments

@rleungx
Copy link
Member

rleungx commented Nov 11, 2021 •
edited
Loading

We can utilize the linters integrated with golangci-lint to enhance code quality. Also see #1919
@rleungx rleungx added the type/enhancement The issue or PR belongs to an enhancement. label Nov 11, 2021
rleungx added a commit to rleungx/pd that referenced this issue Nov 11, 2021
@rleungx
enable more linters
a9b9e15 
ref tikv#4322

Signed-off-by: Ryan Leung <rleungx@gmail.com>
rleungx added a commit to rleungx/pd that referenced this issue Nov 15, 2021
@rleungx
enable more linters
ee10454 
ref tikv#4322

Signed-off-by: Ryan Leung <rleungx@gmail.com>
ti-chi-bot added a commit that referenced this issue Nov 15, 2021
@rleungx @ti-chi-bot
*: enable more linters (#4307)
482b18b 
* enable more linters

ref #4322

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* address the comment

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
@rleungx rleungx added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Nov 29, 2021
rleungx added a commit to rleungx/pd that referenced this issue Dec 7, 2021
@rleungx
enable bodyclose linter
158ebbf 
ref tikv#4322

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx rleungx mentioned this issue Dec 7, 2021
Merged
ti-chi-bot pushed a commit that referenced this issue Dec 8, 2021
@rleungx
*: enable bodyclose linter (#4437)
4ec9e14 
* enable bodyclose linter

ref #4322

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* address the comment

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx rleungx mentioned this issue Jan 14, 2022
Merged
This was referenced Jul 17, 2024
Merged
Closed
@okJiang okJiang mentioned this issue Jul 30, 2024
Closed
@rleungx rleungx mentioned this issue Aug 15, 2024
Merged
ti-chi-bot bot pushed a commit that referenced this issue Aug 15, 2024
@rleungx
*: add linters to organize import dependency (#8532)
1b8fc6a 
ref #4322

Signed-off-by: Ryan Leung <rleungx@gmail.com>
This was referenced Dec 17, 2024
Merged
Merged
Merged
ti-chi-bot bot added a commit that referenced this issue Dec 17, 2024
@rleungx @ti-chi-bot
*: enable gci (#8925)
e907aac 
ref #4322

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@rleungx rleungx mentioned this issue Dec 27, 2024
Merged
ti-chi-bot bot added a commit that referenced this issue Dec 27, 2024
@rleungx @ti-chi-bot
*: fix lint issue (#8953)
5999d64 
ref #4322

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@rleungx rleungx mentioned this issue Dec 30, 2024
Merged
ti-chi-bot bot pushed a commit that referenced this issue Jan 2, 2025
@rleungx
*: format log fields using kebab-case style (#8956)
c2d4854 
ref #4322

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx rleungx mentioned this issue Jan 20, 2025
Merged
ti-chi-bot bot pushed a commit that referenced this issue Jan 21, 2025
@rleungx
*: check file header (#9015)
093b841 
ref #4322

Signed-off-by: Ryan Leung <rleungx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rleungx