Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The RLock will not be released if regionStats equals to nil #4354

Closed
rleungx opened this issue Nov 22, 2021 · 0 comments · Fixed by #4355
Closed

The RLock will not be released if regionStats equals to nil #4354

rleungx opened this issue Nov 22, 2021 · 0 comments · Fixed by #4355
Assignees
@rleungx
Labels
type/bug The issue is confirmed as a bug.

Comments

@rleungx
Copy link
Member

rleungx commented Nov 22, 2021

Bug Report

Screen Shot 2021-11-22 at 3 09 02 PM

The RLock is not released if it returns early.

What version of PD are you using (pd-server -V)?

master
@rleungx rleungx added the type/bug The issue is confirmed as a bug. label Nov 22, 2021
@rleungx rleungx self-assigned this Nov 22, 2021
@rleungx rleungx mentioned this issue Nov 22, 2021
Merged
rleungx added a commit to rleungx/pd that referenced this issue Nov 22, 2021
@rleungx
fix the lock issue
46ad8f7 
close tikv#4354

Signed-off-by: Ryan Leung <rleungx@gmail.com>
rleungx added a commit to rleungx/pd that referenced this issue Nov 22, 2021
@rleungx
fix the RLock issue
d82dc69 
close tikv#4354

Signed-off-by: Ryan Leung <rleungx@gmail.com>
nolouch pushed a commit that referenced this issue Nov 22, 2021
@rleungx @ti-chi-bot
fix the RLock issue (#4355)
dbe5e29 
close #4354

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue Nov 22, 2021
@rleungx @ti-chi-bot
fix the RLock issue
a433f8d 
close tikv#4354

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@ti-chi-bot ti-chi-bot mentioned this issue Nov 22, 2021
Merged
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue Nov 22, 2021
@rleungx @ti-chi-bot
fix the RLock issue
50ec8ef 
close tikv#4354

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@ti-chi-bot ti-chi-bot mentioned this issue Nov 22, 2021
Merged
ti-chi-bot added a commit that referenced this issue Nov 30, 2021
@ti-chi-bot @rleungx
cluster: fix the unreleased RLock issue (#4355) (#4358)
1bb960a 
close #4354

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: Ryan Leung <rleungx@gmail.com>
ti-chi-bot added a commit that referenced this issue Nov 30, 2021
@ti-chi-bot @rleungx
cluster: fix the unreleased RLock issue (#4355) (#4359)
257f7d4 
close #4354

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: Ryan Leung <rleungx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rleungx rleungx

Labels
type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cluster: fix the unreleased RLock issue rleungx/pd
1 participant
@rleungx