Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor hot region related modules #4477

Closed
Tracked by #5691
nolouch opened this issue Dec 17, 2021 · 3 comments
Closed
Tracked by #5691

Refactor hot region related modules #4477

nolouch opened this issue Dec 17, 2021 · 3 comments
Labels
type/development The issue belongs to a development tasks type/feature-request Categorizes issue or PR as related to a new feature.

Comments

@nolouch
Copy link
Contributor

nolouch commented Dec 17, 2021

Motivation

We recently encountered a scheduling problem caused by the statistics module, see the issue for details: #4390

statistics is an important module for scheduling, it is basic and important. I see some problems:

  • Difficult Maintain. For example, hot cache statics have many flags and states, it's hard to maintain.
  • Lack Test. This module is best to prevent problems through a unit test. the unit test should be enhanced.
  • More Robust. Statistics is also the sensor in the feedback system. we should make it more robust even the heartbeat frequency is changed.
@nolouch nolouch added type/feature-request Categorizes issue or PR as related to a new feature. type/development The issue belongs to a development tasks labels Dec 17, 2021
@nolouch nolouch changed the title Refactoring statistics module Refactor statistics module Dec 17, 2021
ti-chi-bot pushed a commit that referenced this issue Feb 23, 2022
ref #4477

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx rleungx changed the title Refactor statistics module Refactor hot region related modules Apr 11, 2022
@lhy1024
Copy link
Contributor

lhy1024 commented Nov 9, 2022

@rleungx Can we close it?

@rleungx
Copy link
Member

rleungx commented Nov 9, 2022

Close it since it has finished.

@rleungx rleungx closed this as completed Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/development The issue belongs to a development tasks type/feature-request Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants