Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DR Auto-Sync: need a timeout mechanism when DR state changes from async to sync_recover #4939

Closed
tshqin opened this issue May 12, 2022 · 0 comments · Fixed by #6295
Closed

DR Auto-Sync: need a timeout mechanism when DR state changes from async to sync_recover #4939

tshqin opened this issue May 12, 2022 · 0 comments · Fixed by #6295
Assignees
@disksing
Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. severity/moderate type/bug The issue is confirmed as a bug.

Comments

@tshqin
Copy link

tshqin commented May 12, 2022 •
edited
Loading

Currently we have the 'wait-store-timeout' configuration item to protect the DR state in 'sync' from short-term jitters.
As we know, either the DR state is 'sync' or 'async', the DR replicas are in ACID consistent state. Unless the DR state is changed to 'sync_recover', we don't guarantee the DR replicas' ACID consistency.
So, we need a timeout in 'async' state to protect the DR replicas' ACID consistency from short-term jitters.
@tshqin tshqin added the type/feature-request Categorizes issue or PR as related to a new feature. label May 12, 2022
@disksing disksing self-assigned this May 16, 2022
@JmPotato JmPotato mentioned this issue Mar 26, 2024
Merged
@JmPotato JmPotato mentioned this issue Mar 26, 2024
Merged
@JmPotato JmPotato added severity/moderate affects-6.5 This bug affects the 6.5.x(LTS) versions. type/bug The issue is confirmed as a bug. and removed type/feature-request Categorizes issue or PR as related to a new feature. labels Mar 26, 2024
ti-chi-bot bot added a commit that referenced this issue Mar 26, 2024
@ti-chi-bot @disksing @ti-chi-bot
dr-autosync: add recover timeout (#6295) (#7347)
667abac 
close #4939

Signed-off-by: husharp <jinhao.hu@pingcap.com>

Co-authored-by: disksing <i@disksing.com>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@rleungx rleungx added affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. labels Nov 6, 2024
This was referenced Nov 6, 2024
Merged
Merged
ti-chi-bot bot added a commit that referenced this issue Nov 11, 2024
@ti-chi-bot @disksing @ti-chi-bot
dr-autosync: add recover timeout (#6295) (#8775)
d347eed 
close #4939

Signed-off-by: husharp <jinhao.hu@pingcap.com>

Co-authored-by: disksing <i@disksing.com>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
ti-chi-bot bot pushed a commit that referenced this issue Dec 5, 2024
@ti-chi-bot @disksing
dr-autosync: add recover timeout (#6295) (#8776)
0035391 
close #4939

Signed-off-by: husharp <jinhao.hu@pingcap.com>

Co-authored-by: disksing <i@disksing.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@disksing disksing

Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. severity/moderate type/bug The issue is confirmed as a bug.
Projects
Questions and Bug Reports
Status: Need Triage
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

dr-autosync: add recover timeout oh-my-tidb/pd
4 participants
@JmPotato @disksing @tshqin @rleungx