Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

should use UnfinishedInfluence in GetOpInfluence #5311

Closed
CabinfeverB opened this issue Jul 14, 2022 · 0 comments · Fixed by #5312
Closed

should use UnfinishedInfluence in GetOpInfluence #5311

CabinfeverB opened this issue Jul 14, 2022 · 0 comments · Fixed by #5312
Labels
affects-6.1 affects-6.2 severity/major type/bug The issue is confirmed as a bug.

Comments

@CabinfeverB
Copy link
Member

Bug Report

#4652
There is a mistake for using AddOpInfluence in GetOpInfluence. It should be used in GetFastOpInfluence
https://github.com/CabinfeverB/pd/blob/785ade2fecb0d07582fb43d394f192204ec88ce8/server/schedule/operator_controller.go#L798

What version of PD are you using (pd-server -V)?

master
@CabinfeverB CabinfeverB added type/bug The issue is confirmed as a bug. severity/major affects-6.1 labels Jul 14, 2022
@CabinfeverB CabinfeverB mentioned this issue Jul 14, 2022
Merged
ti-chi-bot added a commit that referenced this issue Jul 25, 2022
@CabinfeverB @ti-chi-bot
operator: fix bug for using AddOpInfluence (#5312)
e339c83 
close #5311

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue Jul 25, 2022
@CabinfeverB @ti-chi-bot
This is an automated cherry-pick of tikv#5312
181d8fd 
close tikv#5311

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
This was referenced Jul 25, 2022
Merged
Merged
ti-chi-bot added a commit that referenced this issue Jul 26, 2022
@ti-chi-bot @CabinfeverB
operator: fix bug for using AddOpInfluence (#5312) (#5351)
c643f3f 
close #5311, ref #5312

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

Co-authored-by: Cabinfever_B <cabinfeveroier@gmail.com>
ti-chi-bot added a commit that referenced this issue Jul 27, 2022
@ti-chi-bot @CabinfeverB
operator: fix bug for using AddOpInfluence (#5312) (#5350)
f938bd5 
close #5311, ref #5312

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

Co-authored-by: Yongbo Jiang <cabinfeveroier@gmail.com>
Co-authored-by: Cabinfever_B <cabinfeveroier@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-6.1 affects-6.2 severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

operator: fix bug for using AddOpInfluence CabinfeverB/pd
3 participants
@VelocityLight @CabinfeverB @ti-chi-bot