Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unsafe recovery auto detect mode doesn't work #5753

Closed
Connor1996 opened this issue Dec 5, 2022 · 0 comments · Fixed by #5754
Closed

Unsafe recovery auto detect mode doesn't work #5753

Connor1996 opened this issue Dec 5, 2022 · 0 comments · Fixed by #5754
Assignees
@Connor1996
Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. severity/major type/bug The issue is confirmed as a bug.

Comments

@Connor1996
Copy link
Member

Bug Report

What did you do?

Run unsafe recovery auto-detect mode after performing pd recover

What did you expect to see?

Finish successfully

What did you see instead?

get stuck in enter force leader stage and finally timeout.
In TiKV log, it prints Unsafe recovery, reject pre force leader due to has quorum

What version of PD are you using (pd-server -V)?

v6.4.0
@Connor1996 Connor1996 added the type/bug The issue is confirmed as a bug. label Dec 5, 2022
Connor1996 added a commit to Connor1996/pd that referenced this issue Dec 5, 2022
@Connor1996
close tikv#5753 fix unsafe recovery auto detect mode
82fa664 
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
@Connor1996 Connor1996 mentioned this issue Dec 5, 2022
Merged
@nolouch nolouch added the affects-6.5 This bug affects the 6.5.x(LTS) versions. label Dec 5, 2022
@Connor1996 Connor1996 removed the affects-6.1 This bug affects the 6.1.x(LTS) versions. label Dec 5, 2022
ti-chi-bot added a commit that referenced this issue Dec 5, 2022
@Connor1996 @ti-chi-bot
Fix unsafe recovery auto detect mode (#5754)
5f05176 
close #5753

Fix unsafe recovery auto-detect mode by passing detected failed stores to TiKV

Signed-off-by: Connor1996 <zbk602423539@gmail.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this issue Dec 5, 2022
Merged
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue Dec 5, 2022
@Connor1996 @ti-chi-bot
close tikv#5753 fix unsafe recovery auto detect mode
8a4f4ee 
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
ti-chi-bot added a commit that referenced this issue Dec 5, 2022
@ti-chi-bot @Connor1996
Fix unsafe recovery auto detect mode (#5754) (#5756)
5d6c912 
close #5753, ref #5754

Fix unsafe recovery auto-detect mode by passing detected failed stores to TiKV

Signed-off-by: Connor1996 <zbk602423539@gmail.com>

Co-authored-by: Connor1996 <zbk602423539@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Connor1996 Connor1996

Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix unsafe recovery auto detect mode Connor1996/pd
3 participants
@nolouch @Connor1996 @ti-chi-bot