Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics: consider replace resource manager related histogram with counter #6066

Closed
glorv opened this issue Mar 1, 2023 · 2 comments · Fixed by #6332
Closed

metrics: consider replace resource manager related histogram with counter #6066

glorv opened this issue Mar 1, 2023 · 2 comments · Fixed by #6332
Assignees
@HuSharp
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@glorv
Copy link
Contributor

glorv commented Mar 1, 2023

Enhancement Task

Currently, 1 resource group will result in around ~100 metrics. This will be a big problem if we are going to support 10k resource groups in one cluster. Since we only use the count/sum of these histogram, maybe we should replace the with counter to reduce the total data size.
@glorv glorv added the type/enhancement The issue or PR belongs to an enhancement. label Mar 1, 2023
@glorv
Copy link
Contributor Author

glorv commented Mar 1, 2023

/cc @JmPotato @nolouch

@HuSharp
Copy link
Member

HuSharp commented Apr 17, 2023

/assign

@HuSharp HuSharp mentioned this issue Apr 18, 2023
Merged
ti-chi-bot bot pushed a commit that referenced this issue Apr 26, 2023
@HuSharp
resource_manage/metrics: change histogram to vector (#6332)
6ea70e6 
close #6066

resource_manage/metrics: change histogram to vector

Signed-off-by: husharp <jinhao.hu@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HuSharp HuSharp

Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

resource_manage/metrics: change histogram to vector HuSharp/pd
2 participants
@glorv @HuSharp