Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failed to create PD client for PD v6.5/v6.6 #6243

Closed
sleepymole opened this issue Mar 29, 2023 · 2 comments · Fixed by #6244
Closed

Failed to create PD client for PD v6.5/v6.6 #6243

sleepymole opened this issue Mar 29, 2023 · 2 comments · Fixed by #6244
Assignees
@binshi-bing
Labels
affects-7.0 severity/critical type/bug The issue is confirmed as a bug.

Comments

@sleepymole
Copy link
Member

sleepymole commented Mar 29, 2023 •
edited
Loading

Bug Report

What did you do?

Create PD client for PD v6.5/v6.6 using the following function.

pd/client/client.go

Line 305 in c4a8b80

func NewClientWithContext(ctx context.Context, svrAddrs []string, security SecurityOption, opts ...ClientOption) (Client, error) {

What did you expect to see?

Everything is ok.

What did you see instead?

An error encountered:

[pd] failed to get cluster id

Root cause:

pd/client/pd_service_discovery.go

Line 379 in c4a8b80

return errors.WithStack(errFailInitClusterID)

What version of PD are you using (pd-server -V)?

pd-server: v6.6.0
Test codes is based TiDB repo:
github.com/tikv/pd/client v0.0.0-20230329032054-05f86a47e154
https://github.com/pingcap/tidb/blob/4d50a1d9293e934244d46eeb621290565f29391e/go.mod#L97
@sleepymole sleepymole added the type/bug The issue is confirmed as a bug. label Mar 29, 2023
@sleepymole
Copy link
Member Author

sleepymole commented Mar 29, 2023 •
edited
Loading

The issue can cause TiDB Lightning v7.0 to fail to import data to TiDB 6.6.

@rleungx rleungx mentioned this issue Mar 29, 2023
Merged
@rleungx
Copy link
Member

rleungx commented Mar 29, 2023

The problem is introduced by #6160

ti-chi-bot pushed a commit that referenced this issue Mar 29, 2023
@rleungx
client: fix compatibility problem of pd client (#6244)
1948c24 
close #6243

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@ti-chi-bot ti-chi-bot mentioned this issue Mar 29, 2023
Merged
@rleungx rleungx mentioned this issue Mar 29, 2023
Closed
ti-chi-bot added a commit that referenced this issue Mar 29, 2023
@ti-chi-bot @rleungx
client: fix compatibility problem of pd client (#6244) (#6245)
da5a4e9 
close #6243, ref #6244

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: Ryan Leung <rleungx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@binshi-bing binshi-bing

Labels
affects-7.0 severity/critical type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

client: fix compatibility problem of pd client rleungx/pd
5 participants
@VelocityLight @sleepymole @rleungx @binshi-bing @ti-chi-bot