Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The context timeout may cause lease timeout #6926

Closed
rleungx opened this issue Aug 9, 2023 · 0 comments · Fixed by #6925
Closed

The context timeout may cause lease timeout #6926

rleungx opened this issue Aug 9, 2023 · 0 comments · Fixed by #6925
Labels
affects-5.3 affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. severity/major type/bug The issue is confirmed as a bug.

Comments

@rleungx
Copy link
Member

rleungx commented Aug 9, 2023

Bug Report

The lease timeout without logging lease keep alive failed. The context may be canceled due to timeout if the keep alive costs too much time. The request could succeed but it has a little probability that the new expiration time is lost.

[2023/08/08 09:05:18.883 +00:00] [INFO] [lease.go:119] ["lease timeout"] [expire=2023/08/08 09:05:20.874 +00:00] [purpose="pd leader election"]
[2023/08/08 09:05:18.883 +00:00] [INFO] [lease.go:159] ["stop lease keep alive worker"] [purpose="pd leader election"]
@rleungx rleungx added the type/bug The issue is confirmed as a bug. label Aug 9, 2023
@rleungx rleungx mentioned this issue Aug 9, 2023
Merged
@rleungx rleungx added affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-5.0 affects-5.1 affects-5.2 affects-5.3 affects-5.4 This bug affects the 5.4.x(LTS) versions. severity/major and removed affects-5.0 affects-5.1 affects-5.2 affects-5.3 affects-5.4 This bug affects the 5.4.x(LTS) versions. labels Aug 10, 2023
ti-chi-bot bot added a commit that referenced this issue Aug 10, 2023
@rleungx @ti-chi-bot
election: fix the keep alive worker (#6925)
9d2f650 
close #6926

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
This was referenced Aug 10, 2023
Closed
Merged
This was referenced Aug 10, 2023
Merged
Merged
Merged
ti-chi-bot bot added a commit that referenced this issue Aug 14, 2023
@ti-chi-bot @rleungx @ti-chi-bot
election: fix the keep alive worker (#6925) (#6940)
3a19dec 
close #6926

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: Ryan Leung <rleungx@gmail.com>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
ti-chi-bot bot added a commit that referenced this issue Sep 26, 2023
@ti-chi-bot @rleungx @ti-chi-bot
election: fix the keep alive worker (#6925) (#6941)
aeb2593 
close #6926

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: Ryan Leung <rleungx@gmail.com>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@niubell niubell mentioned this issue Oct 18, 2023
Merged
18 tasks
ti-chi-bot bot pushed a commit that referenced this issue Sep 11, 2024
@ti-chi-bot @rleungx
election: fix the keep alive worker (#6925) (#6939)
d76f55d 
close #6926

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: Ryan Leung <rleungx@gmail.com>
ti-chi-bot bot pushed a commit that referenced this issue Sep 11, 2024
@ti-chi-bot @rleungx
election: fix the keep alive worker (#6925) (#6938)
b9042a9 
close #6926

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: Ryan Leung <rleungx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-5.3 affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

election: fix the keep alive worker rleungx/pd
1 participant
@rleungx