Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow return resource group priority in resource interceptor #7379

Closed
glorv opened this issue Nov 16, 2023 · 2 comments · Fixed by #7378
Closed

Allow return resource group priority in resource interceptor #7379

glorv opened this issue Nov 16, 2023 · 2 comments · Fixed by #7378
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@glorv
Copy link
Contributor

glorv commented Nov 16, 2023 •
edited
Loading

Enhancement Task

In tikv/tikv#15966, tikv tried to set the resource group priority when it receive a request, but this caused a performance regression, so I decide to move this logic into the client side.
@glorv glorv added the type/enhancement The issue or PR belongs to an enhancement. label Nov 16, 2023
@glorv glorv mentioned this issue Nov 16, 2023
Merged
@glorv
Copy link
Contributor Author

glorv commented Nov 16, 2023

/label severity/minor

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 16, 2023

@glorv: The label(s) severity/minor cannot be applied. These labels are supported: Hacktoberfest, challenge-program, ci-unstable, compatibility-breaker, high-performance, hptc, needs-cherry-pick-release-5.3, needs-cherry-pick-release-5.4, needs-cherry-pick-release-6.1, needs-cherry-pick-release-6.5, needs-cherry-pick-release-7.1, needs-cherry-pick-release-7.5, release-note, require-LGT1, wontfix, affects-5.3, affects-5.4, affects-6.1, affects-6.5, affects-7.1, affects-7.5, may-affects-5.3, may-affects-5.4, may-affects-6.1, may-affects-6.5, may-affects-7.1, may-affects-7.5.

In response to this:

/label severity/minor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot bot added a commit that referenced this issue Nov 16, 2023
@glorv @ti-chi-bot
resourcemanager: return resource-group priority in OnRequestWait (#7378)
4e600c2 
close #7379, ref tikv/tikv#15994

Signed-off-by: glorv <glorvs@163.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@ti-chi-bot ti-chi-bot mentioned this issue Nov 16, 2023
Merged
ti-chi-bot bot pushed a commit that referenced this issue Nov 16, 2023
@ti-chi-bot @glorv @JmPotato
resourcemanager: return resource-group priority in OnRequestWait (#7378…
ef6ba85 
…) (#7383)

close #7379, ref tikv/tikv#15994

Signed-off-by: glorv <glorvs@163.com>
Signed-off-by: JmPotato <ghzpotato@gmail.com>

Co-authored-by: glorv <glorvs@163.com>
Co-authored-by: JmPotato <ghzpotato@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

resourcemanager: return resource-group priority in OnRequestWait glorv/pd
1 participant
@glorv