Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resetTS should use suitable status code #7411

Closed
lhy1024 opened this issue Nov 22, 2023 · 1 comment · Fixed by #7368
Closed

resetTS should use suitable status code #7411

lhy1024 opened this issue Nov 22, 2023 · 1 comment · Fixed by #7368
Assignees
@lhy1024
Labels
severity/moderate type/bug The issue is confirmed as a bug.

Comments

@lhy1024
Copy link
Contributor

lhy1024 commented Nov 22, 2023 •
edited
Loading

Bug Report

What did you do?

Test

What did you expect to see?

The server returns a suitable status code when meeting ErrEtcdTxnConflict

What did you see instead?

The server returns 403 when meeting any errors, but for temporary failure, we should return 503

https://datatracker.ietf.org/doc/html/rfc7231#section-6.6.4

What version of PD are you using (pd-server -V)?

master
@lhy1024 lhy1024 added type/bug The issue is confirmed as a bug. severity/moderate labels Nov 22, 2023
@lhy1024 lhy1024 self-assigned this Nov 22, 2023
@lhy1024
Copy link
Contributor Author

lhy1024 commented Nov 22, 2023

After discussion with @niubell, we will only fix it on master branch.

@lhy1024 lhy1024 mentioned this issue Nov 22, 2023
Merged
ti-chi-bot bot added a commit that referenced this issue Nov 22, 2023
@lhy1024 @ti-chi-bot
api: use suitable status code and make TestResetTS stable (#7368)
8e6dcfb 
close #7411

Signed-off-by: lhy1024 <admin@liudos.us>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
rleungx pushed a commit to rleungx/pd that referenced this issue Dec 1, 2023
@lhy1024 @ti-chi-bot @rleungx
api: use suitable status code and make TestResetTS stable (tikv#7368)
175dff8 
close tikv#7411

Signed-off-by: lhy1024 <admin@liudos.us>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lhy1024 lhy1024

Labels
severity/moderate type/bug The issue is confirmed as a bug.
Projects
Questions and Bug Reports
Status: Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

api: use suitable status code and make TestResetTS stable lhy1024/pd
1 participant
@lhy1024