Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestConfigTestSuite is unstable #7440

Closed
HuSharp opened this issue Nov 24, 2023 · 4 comments · Fixed by #7463
Closed

TestConfigTestSuite is unstable #7440

HuSharp opened this issue Nov 24, 2023 · 4 comments · Fixed by #7463
Labels
type/ci The issue is related to CI.

Comments

@HuSharp
Copy link
Member

HuSharp commented Nov 24, 2023

Flaky Test

TestConfigTestSuite

Which jobs are failing

2023-11-24T09:13:41.3004455Z --- FAIL: TestConfigTestSuite (59.50s)
2023-11-24T09:13:41.3004734Z     --- FAIL: TestConfigTestSuite/TestConfig (7.51s)
2023-11-24T09:13:41.3005090Z         testutil.go:265: start to run test in pd mode
2023-11-24T09:13:41.3005419Z         testutil.go:269: finish to run test in pd mode
2023-11-24T09:13:41.3005674Z         testutil.go:274: start to run test in api mode
2023-11-24T09:13:41.3005960Z         config_test.go:109: 
2023-11-24T09:13:41.3006490Z             	Error Trace:	/home/runner/work/pd/pd/tests/pdctl/config/config_test.go:109
2023-11-24T09:13:41.3007316Z             	            				/home/runner/work/pd/pd/tests/testutil.go:279
2023-11-24T09:13:41.3007985Z             	            				/home/runner/work/pd/pd/tests/testutil.go:260
2023-11-24T09:13:41.3009023Z             	            				/home/runner/work/pd/pd/tests/pdctl/config/config_test.go:64
2023-11-24T09:13:41.3009346Z             	Error:      	Should be false
2023-11-24T09:13:41.3009653Z             	Test:       	TestConfigTestSuite/TestConfig

CI link

https://github.com/tikv/pd/actions/runs/6978834150/job/18990966346
https://github.com/tikv/pd/actions/runs/6973238800/job/18976877533

Reason for failure (if possible)

Anything else

@HuSharp HuSharp added the type/ci The issue is related to CI. label Nov 24, 2023
@rleungx
Copy link
Member

rleungx commented Nov 28, 2023

We can find from the log, the trace-region-flow is updated to false:

[2023/11/24 09:12:41.169 +00:00] [INFO] [audit.go:126] ["audit log"] [service-info="{ServiceLabel:SetConfig, Method:HTTP/1.1/POST:/pd/api/v1/config, Component:pdctl, IP:127.0.0.1, Port:40408, StartTime:2023-11-24 09:12:41 +0000 UTC, URLParam:{}, BodyParam:{\"trace-region-flow\":\"false\"}}"]
...
[2023/11/24 09:12:41.175 +00:00] [INFO] [server.go:1258] ["PD server config is updated"] [new="{\"use-region-storage\":\"true\",\"max-gap-reset-ts\":\"24h0m0s\",\"key-type\":\"table\",\"runtime-services\":\"\",\"metric-storage\":\"\",\"dashboard-address\":\"auto\",\"flow-round-by-digit\":3,\"min-resolved-ts-persistence-interval\":\"1s\",\"server-memory-limit\":0,\"server-memory-limit-gc-trigger\":0.7,\"enable-gogc-tuner\":\"false\",\"gc-tuner-threshold\":0.6,\"block-safe-point-v1\":\"false\"}"] [old="{\"use-region-storage\":\"true\",\"max-gap-reset-ts\":\"24h0m0s\",\"key-type\":\"table\",\"runtime-services\":\"\",\"metric-storage\":\"\",\"dashboard-address\":\"auto\",\"trace-region-flow\":\"true\",\"flow-round-by-digit\":3,\"min-resolved-ts-persistence-interval\":\"1s\",\"server-memory-limit\":0,\"server-memory-limit-gc-trigger\":0.7,\"enable-gogc-tuner\":\"false\",\"gc-tuner-threshold\":0.6,\"block-safe-point-v1\":\"false\"}"]

But later, it is changed back because of the dashboard address check goroutine:

[2023/11/24 09:12:41.180 +00:00] [INFO] [server.go:1258] ["PD server config is updated"] [new="{\"use-region-storage\":\"true\",\"max-gap-reset-ts\":\"24h0m0s\",\"key-type\":\"table\",\"runtime-services\":\"\",\"metric-storage\":\"\",\"dashboard-address\":\"[http://127.0.0.1:40831\](http://127.0.0.1:40831/)",\"trace-region-flow\":\"true\",\"flow-round-by-digit\":3,\"min-resolved-ts-persistence-interval\":\"1s\",\"server-memory-limit\":0,\"server-memory-limit-gc-trigger\":0.7,\"enable-gogc-tuner\":\"false\",\"gc-tuner-threshold\":0.6,\"block-safe-point-v1\":\"false\"}"] [old="{\"use-region-storage\":\"true\",\"max-gap-reset-ts\":\"24h0m0s\",\"key-type\":\"table\",\"runtime-services\":\"\",\"metric-storage\":\"\",\"dashboard-address\":\"auto\",\"flow-round-by-digit\":3,\"min-resolved-ts-persistence-interval\":\"1s\",\"server-memory-limit\":0,\"server-memory-limit-gc-trigger\":0.7,\"enable-gogc-tuner\":\"false\",\"gc-tuner-threshold\":0.6,\"block-safe-point-v1\":\"false\"}"]

@rleungx
Copy link
Member

rleungx commented Nov 28, 2023

Tracking Issue: #7464

ti-chi-bot bot added a commit that referenced this issue Nov 29, 2023
close #7440

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
rleungx added a commit to rleungx/pd that referenced this issue Dec 1, 2023
close tikv#7440

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@okJiang

This comment was marked as off-topic.

@rleungx rleungx reopened this Jul 18, 2024
@okJiang
Copy link
Member

okJiang commented Jul 18, 2024

This is not the same test, you can close it, sorry 😂

@rleungx rleungx closed this as completed Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/ci The issue is related to CI.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants