Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redundant grpc headers add unwanted network overhead #7469

Closed
CabinfeverB opened this issue Nov 29, 2023 · 0 comments · Fixed by #7471
Closed

Redundant grpc headers add unwanted network overhead #7469

CabinfeverB opened this issue Nov 29, 2023 · 0 comments · Fixed by #7471
Labels
severity/minor type/bug The issue is confirmed as a bug.

Comments

@CabinfeverB
Copy link
Member

Bug Report

Now pd client usesBuildForwardContext whether client need to forward or not

image
That's about 10% more bytes

What did you do?

What did you expect to see?

What did you see instead?

What version of PD are you using (pd-server -V)?
@CabinfeverB CabinfeverB added type/bug The issue is confirmed as a bug. severity/major affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. labels Nov 29, 2023
@CabinfeverB CabinfeverB mentioned this issue Nov 29, 2023
Merged
ti-chi-bot bot added a commit that referenced this issue Nov 29, 2023
@CabinfeverB @ti-chi-bot
client: avoid to add redundant grpc metadata (#7471)
180ff57 
close #7469

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@ti-chi-bot ti-chi-bot mentioned this issue Nov 29, 2023
Closed
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue Nov 29, 2023
@CabinfeverB @ti-chi-bot
This is an automated cherry-pick of tikv#7471
3883864 
close tikv#7469

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this issue Nov 29, 2023
Closed
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue Nov 29, 2023
@CabinfeverB @ti-chi-bot
This is an automated cherry-pick of tikv#7471
50c12b3 
close tikv#7469

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this issue Nov 29, 2023
Closed
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue Nov 29, 2023
@CabinfeverB @ti-chi-bot
This is an automated cherry-pick of tikv#7471
207bf2a 
close tikv#7469

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this issue Nov 29, 2023
Closed
@CabinfeverB CabinfeverB added severity/minor and removed affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. severity/major labels Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
severity/minor type/bug The issue is confirmed as a bug.
Projects
Questions and Bug Reports
Status: Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

client: avoid to add redundant grpc metadata CabinfeverB/pd
1 participant
@CabinfeverB