Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mcs: a lot of redirect but server is not leader in test #7533

Closed
lhy1024 opened this issue Dec 12, 2023 · 1 comment · Fixed by #7538
Closed

mcs: a lot of redirect but server is not leader in test #7533

lhy1024 opened this issue Dec 12, 2023 · 1 comment · Fixed by #7538
Assignees
@lhy1024
Labels
severity/moderate type/bug The issue is confirmed as a bug.

Comments

@lhy1024
Copy link
Contributor

lhy1024 commented Dec 12, 2023

Bug Report

What did you do?

run placement rules test but failed
https://tcms.pingcap.net/dashboard/executions/plan/5131009

What did you expect to see?

success

What did you see instead?

image

What version of PD are you using (pd-server -V)?
@lhy1024 lhy1024 added the type/bug The issue is confirmed as a bug. label Dec 12, 2023
@lhy1024
Copy link
Contributor Author

lhy1024 commented Dec 13, 2023

In this case, the follower forwards to the leader, and the leader forwards to scheduling. The second forwarding will fail because of the existing PDRedirectorHeader.

In reality, we should only check for PDRedirectorHeader among the PD/API server.

@lhy1024 lhy1024 mentioned this issue Dec 13, 2023
Merged
@lhy1024 lhy1024 self-assigned this Dec 13, 2023
ti-chi-bot bot pushed a commit that referenced this issue Dec 13, 2023
@lhy1024 @rleungx
mcs: fix unnecessary PDRedirectorHeader (#7538)
48fabb7 
close #7533

Signed-off-by: lhy1024 <admin@liudos.us>

Co-authored-by: Ryan Leung <rleungx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lhy1024 lhy1024

Labels
severity/moderate type/bug The issue is confirmed as a bug.
Projects
Questions and Bug Reports
Status: Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

mcs: fix unnecessary PDRedirectorHeader lhy1024/pd
1 participant
@lhy1024