Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestRedirectWithMetrics date race #7639

Closed
HuSharp opened this issue Dec 29, 2023 · 0 comments · Fixed by #7640
Closed

TestRedirectWithMetrics date race #7639

HuSharp opened this issue Dec 29, 2023 · 0 comments · Fixed by #7640
Assignees
@HuSharp
Labels
type/ci The issue is related to CI.

Comments

@HuSharp
Copy link
Member

HuSharp commented Dec 29, 2023

Flaky Test

Which jobs are failing

==================
WARNING: DATA RACE
Write at 0x00c0000282c8 by goroutine 20:
  github.com/tikv/pd/client/http.TestRedirectWithMetrics()
      /home/runner/work/pd/pd/client/http/client_test.go:138 +0xa33
  testing.tRunner()
      /opt/hostedtoolcache/go/1.21.5/x64/src/testing/testing.go:1595 +0x261
  testing.(*T).Run.func1()
      /opt/hostedtoolcache/go/1.21.5/x64/src/testing/testing.go:1648 +0x44

Previous read at 0x00c0000282c8 by goroutine 21:
  github.com/tikv/pd/client/http.(*clientInner).getPDAddrs()
      /home/runner/work/pd/pd/client/http/client.go:103 +0x124
  github.com/tikv/pd/client/http.(*clientInner).requestWithRetry()
      /home/runner/work/pd/pd/client/http/client.go:151 +0xb6
  github.com/tikv/pd/client/http.(*clientInner).updateMembersInfo()
      /home/runner/work/pd/pd/client/http/client.go:277 +0x4d1
  github.com/tikv/pd/client/http.(*clientInner).membersInfoUpdater()
      /home/runner/work/pd/pd/client/http/client.go:260 +0xa6
  github.com/tikv/pd/client/http.(*clientInner).init.func1()
      /home/runner/work/pd/pd/client/http/client.go:89 +0x4f

Goroutine 20 (running) created at:
  testing.(*T).Run()
      /opt/hostedtoolcache/go/1.21.5/x64/src/testing/testing.go:1648 +0x845
  testing.runTests.func1()
      /opt/hostedtoolcache/go/1.21.5/x64/src/testing/testing.go:2054 +0x84
  testing.tRunner()
      /opt/hostedtoolcache/go/1.21.5/x64/src/testing/testing.go:1595 +0x261
  testing.runTests()
      /opt/hostedtoolcache/go/1.21.5/x64/src/testing/testing.go:2052 +0x8ad
  testing.(*M).Run()
      /opt/hostedtoolcache/go/1.21.5/x64/src/testing/testing.go:1925 +0xcd7
  main.main()
      _testmain.go:95 +0x2e4

Goroutine 21 (running) created at:
  github.com/tikv/pd/client/http.(*clientInner).init()
      /home/runner/work/pd/pd/client/http/client.go:89 +0x364
  github.com/tikv/pd/client/http.NewClient()

CI link

https://github.com/tikv/pd/actions/runs/7353320243/job/20019151059?pr=7619

Reason for failure (if possible)

Anything else
@HuSharp HuSharp added the type/ci The issue is related to CI. label Dec 29, 2023
@HuSharp HuSharp self-assigned this Dec 29, 2023
@HuSharp HuSharp mentioned this issue Dec 29, 2023
Merged
ti-chi-bot bot added a commit that referenced this issue Dec 29, 2023
@HuSharp @ti-chi-bot
test: fix TestRedirectWithMetrics data race (#7640)
cf22c04 
close #7639

Signed-off-by: husharp <jinhao.hu@pingcap.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
pingandb pushed a commit to pingandb/pd that referenced this issue Jan 18, 2024
@HuSharp @ti-chi-bot @pingandb
test: fix TestRedirectWithMetrics data race (tikv#7640)
780e525 
close tikv#7639

Signed-off-by: husharp <jinhao.hu@pingcap.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Signed-off-by: pingandb <songge102@pingan.com.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HuSharp HuSharp

Labels
type/ci The issue is related to CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: fix TestRedirectWithMetrics data race HuSharp/pd
1 participant
@HuSharp