Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only one pd instance have trace-region-flow config by query in v6.5.6 #7917

Closed
River2000i opened this issue Mar 14, 2024 · 0 comments · Fixed by #7993
Closed

only one pd instance have trace-region-flow config by query in v6.5.6 #7917

River2000i opened this issue Mar 14, 2024 · 0 comments · Fixed by #7993

Comments

@River2000i
Copy link

Bug Report

What did you do?

  1. use tiup deploy a v6.5.6 cluster
tiup playground v6.5.6 --db.port 4002 --db 1 --kv 1 --tiflash 0 --pd 3
  1. check pd config
mysql> show config where name like "%pd-server.trace-region-flow%";
+------+----------------+-----------------------------+-------+
| Type | Instance       | Name                        | Value |
+------+----------------+-----------------------------+-------+
| pd   | 127.0.0.1:2382 | pd-server.trace-region-flow | true  |
+------+----------------+-----------------------------+-------+
1 row in set (0.01 sec)

mysql> select version();
+--------------------+
| version()          |
+--------------------+
| 5.7.25-TiDB-v6.5.6 |
+--------------------+
1 row in set (0.00 sec)

What did you expect to see?

seem the config is deprecated in
https://github.com/tikv/pd/blob/release-6.5/server/config/config.go#L1163-L1165

maybe can not get this config? only this pd instance print this log
image

and actually all pd instances have trace-region-flow config

What did you see instead?

What version of PD are you using (pd-server -V)?

Release Version: v6.5.6
Edition: Community
Git Commit Hash: 54bdbc3bfbc384229a59e47bdbdf19bc5969b468
Git Branch: heads/refs/tags/v6.5.6
UTC Build Time:  2023-11-28 05:25:32
@River2000i River2000i added the type/bug The issue is confirmed as a bug. label Mar 14, 2024
ti-chi-bot bot added a commit that referenced this issue Mar 29, 2024
close #7917

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
ti-chi-bot bot pushed a commit that referenced this issue Apr 1, 2024
close #7917

Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: JmPotato <ghzpotato@gmail.com>

Co-authored-by: Ryan Leung <rleungx@gmail.com>
Co-authored-by: JmPotato <ghzpotato@gmail.com>
ti-chi-bot bot pushed a commit that referenced this issue Apr 1, 2024
ref #7917

Remove unused `defaultTraceRegionFlow`.

Signed-off-by: JmPotato <ghzpotato@gmail.com>
ti-chi-bot bot pushed a commit that referenced this issue Apr 16, 2024
close #7917

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: Ryan Leung <rleungx@gmail.com>
ti-chi-bot bot pushed a commit that referenced this issue May 13, 2024
close #7917

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: Ryan Leung <rleungx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

3 participants