Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use one linter #8019

Closed
rleungx opened this issue Apr 3, 2024 · 0 comments · Fixed by #8015
Closed

Use one linter #8019

rleungx opened this issue Apr 3, 2024 · 0 comments · Fixed by #8015
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@rleungx
Copy link
Member

rleungx commented Apr 3, 2024

Enhancement Task

We run both golangci-lint and revive linter when executing make check. It's better to only use one of them. Since golangci-lint is more powerful, it seems to support revive internally. we'd better only keep golangci-lint.
@rleungx rleungx added the type/enhancement The issue or PR belongs to an enhancement. label Apr 3, 2024
@rleungx rleungx mentioned this issue Apr 3, 2024
Merged
ti-chi-bot bot added a commit that referenced this issue Apr 11, 2024
@rleungx @ti-chi-bot
*: improve the linter and fix some bugs (#8015)
7e18a69 
close #8019

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

*: improve the linter and fix some bugs rleungx/pd
1 participant
@rleungx