Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rc: group change will meet data race #8267

Closed
HuSharp opened this issue Jun 6, 2024 · 0 comments · Fixed by #8268
Closed

rc: group change will meet data race #8267

HuSharp opened this issue Jun 6, 2024 · 0 comments · Fixed by #8268
Labels
affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. severity/major type/bug The issue is confirmed as a bug.

Comments

@HuSharp
Copy link
Member

HuSharp commented Jun 6, 2024

Bug Report

==================
WARNING: DATA RACE
Write at 0x00c0014f5b30 by goroutine 513:
  github.com/tikv/pd/pkg/mcs/resourcemanager/server.(*Manager).Init()
      /data/nvme0n1/husharp/proj/pd/pkg/mcs/resourcemanager/server/manager.go:132 +0x5d1
  github.com/tikv/pd/pkg/mcs/resourcemanager/server.(*Manager).Init-fm()
      <autogenerated>:1 +0x47
  github.com/tikv/pd/server.(*Server).campaignLeader()
      /data/nvme0n1/husharp/proj/pd/server/server.go:1772 +0x1742
  github.com/tikv/pd/server.(*Server).leaderLoop()
      /data/nvme0n1/husharp/proj/pd/server/server.go:1699 +0x1444
  github.com/tikv/pd/server.(*Server).startServerLoop.func1()
      /data/nvme0n1/husharp/proj/pd/server/server.go:658 +0x33

Previous read at 0x00c0014f5b30 by goroutine 29900015:
  github.com/tikv/pd/pkg/mcs/resourcemanager/server.(*Manager).backgroundMetricsFlush()
      /data/nvme0n1/husharp/proj/pd/pkg/mcs/resourcemanager/server/manager.go:480 +0x12ed
  github.com/tikv/pd/pkg/mcs/resourcemanager/server.(*Manager).Init.func4()
      /data/nvme0n1/husharp/proj/pd/pkg/mcs/resourcemanager/server/manager.go:180 +0x4f

What did you do?

run pd-server

What did you expect to see?

no data race

What did you see instead?

meet data race

What version of PD are you using (pd-server -V)?

494c0e9
@HuSharp HuSharp added the type/bug The issue is confirmed as a bug. label Jun 6, 2024
@HuSharp HuSharp mentioned this issue Jun 6, 2024
Merged
@HuSharp HuSharp mentioned this issue Jun 7, 2024
Merged
@HuSharp HuSharp added affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. and removed may-affects-5.4 may-affects-6.1 may-affects-6.5 may-affects-7.1 may-affects-7.5 may-affects-8.1 labels Jun 7, 2024
ti-chi-bot bot added a commit that referenced this issue Jun 11, 2024
@HuSharp @ti-chi-bot
rc: fix group change will meet data race (#8268)
c015f14 
close #8267

Signed-off-by: husharp <jinhao.hu@pingcap.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
This was referenced Jun 17, 2024
Merged
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this issue Jun 17, 2024
@ti-chi-bot @HuSharp
rc: fix group change will meet data race (#8268) (#8293)
4943b5c 
close #8267

Signed-off-by: husharp <jinhao.hu@pingcap.com>

Co-authored-by: husharp <jinhao.hu@pingcap.com>
ti-chi-bot bot pushed a commit that referenced this issue Jun 17, 2024
@ti-chi-bot @HuSharp
rc: fix group change will meet data race (#8268) (#8294)
22c5c9e 
close #8267

Signed-off-by: husharp <jinhao.hu@pingcap.com>

Co-authored-by: husharp <jinhao.hu@pingcap.com>
ti-chi-bot bot pushed a commit that referenced this issue Jun 17, 2024
@ti-chi-bot @HuSharp
rc: fix group change will meet data race (#8268) (#8292)
c2928cd 
close #8267

Signed-off-by: husharp <jinhao.hu@pingcap.com>

Co-authored-by: husharp <jinhao.hu@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. severity/major type/bug The issue is confirmed as a bug.
Projects
Questions and Bug Reports
Status: Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rc: fix group change will meet data race HuSharp/pd
2 participants
@jebter @HuSharp