-
Notifications
You must be signed in to change notification settings - Fork 725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Size configuration on the TIKV side may cause PD panic #8323
Labels
affects-6.1
This bug affects the 6.1.x(LTS) versions.
affects-6.5
This bug affects the 6.5.x(LTS) versions.
affects-7.1
This bug affects the 7.1.x(LTS) versions.
affects-7.5
This bug affects the 7.5.x(LTS) versions.
affects-8.1
This bug affects the 8.1.x(LTS) versions.
impact/panic
severity/major
type/bug
The issue is confirmed as a bug.
Comments
JmPotato
added
affects-6.5
This bug affects the 6.5.x(LTS) versions.
affects-7.1
This bug affects the 7.1.x(LTS) versions.
affects-7.5
This bug affects the 7.5.x(LTS) versions.
affects-8.1
This bug affects the 8.1.x(LTS) versions.
and removed
may-affects-5.4
may-affects-6.1
may-affects-6.5
may-affects-7.1
may-affects-7.5
may-affects-8.1
labels
Jun 25, 2024
ti-chi-bot bot
pushed a commit
that referenced
this issue
Jun 25, 2024
close #8323 Bypass the case that `RegionSplitSizeMB` might be zero in `(*StoreConfig) CheckRegionSize`. Signed-off-by: JmPotato <ghzpotato@gmail.com>
ti-chi-bot
pushed a commit
to ti-chi-bot/pd
that referenced
this issue
Jun 25, 2024
close tikv#8323 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot
pushed a commit
to ti-chi-bot/pd
that referenced
this issue
Jun 25, 2024
close tikv#8323 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot
pushed a commit
to ti-chi-bot/pd
that referenced
this issue
Jun 25, 2024
close tikv#8323 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
This was referenced Jun 25, 2024
ti-chi-bot
pushed a commit
to ti-chi-bot/pd
that referenced
this issue
Jun 25, 2024
close tikv#8323 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot
pushed a commit
to ti-chi-bot/pd
that referenced
this issue
Jun 25, 2024
close tikv#8323 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot bot
pushed a commit
that referenced
this issue
Jun 26, 2024
close #8323 Bypass the case that `RegionSplitSizeMB` might be zero in `(*StoreConfig) CheckRegionSize`. Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> Signed-off-by: JmPotato <ghzpotato@gmail.com> Co-authored-by: JmPotato <ghzpotato@gmail.com>
ti-chi-bot bot
pushed a commit
that referenced
this issue
Jun 26, 2024
close #8323 Bypass the case that `RegionSplitSizeMB` might be zero in `(*StoreConfig) CheckRegionSize`. Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> Signed-off-by: JmPotato <ghzpotato@gmail.com> Co-authored-by: JmPotato <ghzpotato@gmail.com>
ti-chi-bot bot
pushed a commit
that referenced
this issue
Jun 26, 2024
close #8323 Bypass the case that `RegionSplitSizeMB` might be zero in `(*StoreConfig) CheckRegionSize`. Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> Signed-off-by: JmPotato <ghzpotato@gmail.com> Co-authored-by: JmPotato <ghzpotato@gmail.com>
ti-chi-bot bot
pushed a commit
that referenced
this issue
Jun 26, 2024
close #8323 Bypass the case that `RegionSplitSizeMB` might be zero in `(*StoreConfig) CheckRegionSize`. Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> Signed-off-by: JmPotato <ghzpotato@gmail.com> Co-authored-by: JmPotato <ghzpotato@gmail.com>
ti-chi-bot bot
pushed a commit
that referenced
this issue
Jun 26, 2024
close #8323 Bypass the case that `RegionSplitSizeMB` might be zero in `(*StoreConfig) CheckRegionSize`. Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> Signed-off-by: JmPotato <ghzpotato@gmail.com> Co-authored-by: JmPotato <ghzpotato@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
affects-6.1
This bug affects the 6.1.x(LTS) versions.
affects-6.5
This bug affects the 6.5.x(LTS) versions.
affects-7.1
This bug affects the 7.1.x(LTS) versions.
affects-7.5
This bug affects the 7.5.x(LTS) versions.
affects-8.1
This bug affects the 8.1.x(LTS) versions.
impact/panic
severity/major
type/bug
The issue is confirmed as a bug.
Bug Report
If set
coprocessor.region-split-size
to a value that is less than 1 MiB, it will cause PD panic due to the following code:pd/pkg/schedule/config/store_config.go
Line 171 in 6ae7b47
GetRegionSplitSize()
will return a zero value parsed byParseMBFromText()
, which will return 0 if the given size is less than 1 MiB.pd/pkg/utils/typeutil/size.go
Lines 27 to 36 in 6ae7b47
The text was updated successfully, but these errors were encountered: