-
Notifications
You must be signed in to change notification settings - Fork 725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
An invalid err != nil check may cause the merged TS inconsistent #8524
Labels
affects-7.5
This bug affects the 7.5.x(LTS) versions.
affects-8.1
This bug affects the 8.1.x(LTS) versions.
affects-8.3
component/keyspace
Key space.
component/tso
Timestamp Oracle.
severity/critical
type/bug
The issue is confirmed as a bug.
Comments
JmPotato
added
type/bug
The issue is confirmed as a bug.
component/tso
Timestamp Oracle.
component/keyspace
Key space.
labels
Aug 14, 2024
JmPotato
added
affects-7.5
This bug affects the 7.5.x(LTS) versions.
affects-8.1
This bug affects the 8.1.x(LTS) versions.
and removed
may-affects-5.4
may-affects-6.1
may-affects-6.5
may-affects-7.1
may-affects-7.5
may-affects-8.1
labels
Aug 14, 2024
This was referenced Aug 14, 2024
JmPotato
added a commit
to JmPotato/pd
that referenced
this issue
Aug 14, 2024
close tikv#8524 Use the continue label to retry the whole merge loop correctly. Signed-off-by: JmPotato <ghzpotato@gmail.com>
ti-chi-bot bot
added a commit
that referenced
this issue
Sep 14, 2024
close #8524 Use the continue label to retry the whole merge loop correctly. Signed-off-by: JmPotato <ghzpotato@gmail.com> Signed-off-by: Ryan Leung <rleungx@gmail.com> Co-authored-by: JmPotato <ghzpotato@gmail.com> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com> Co-authored-by: Ryan Leung <rleungx@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
affects-7.5
This bug affects the 7.5.x(LTS) versions.
affects-8.1
This bug affects the 8.1.x(LTS) versions.
affects-8.3
component/keyspace
Key space.
component/tso
Timestamp Oracle.
severity/critical
type/bug
The issue is confirmed as a bug.
Bug Report
pd/pkg/tso/keyspace_group_manager.go
Lines 1365 to 1384 in 1c1cd99
Since the
err
in the loop is a local variable, so the check at line 1382 will always be false.The text was updated successfully, but these errors were encountered: