-
Notifications
You must be signed in to change notification settings - Fork 739
Closed
Labels
affects-7.5This bug affects the 7.5.x(LTS) versions.This bug affects the 7.5.x(LTS) versions.affects-8.1This bug affects the 8.1.x(LTS) versions.This bug affects the 8.1.x(LTS) versions.affects-8.3component/keyspaceKey space.Key space.component/tsoTimestamp Oracle.Timestamp Oracle.severity/criticaltype/bugThe issue is confirmed as a bug.The issue is confirmed as a bug.
Description
Bug Report
pd/pkg/tso/keyspace_group_manager.go
Lines 1365 to 1384 in 1c1cd99
var mergedTS time.Time | |
for _, id := range mergeList { | |
ts, err := kgm.tsoSvcStorage.LoadTimestamp(endpoint.KeyspaceGroupGlobalTSPath(id)) | |
if err != nil { | |
log.Error("failed to load the keyspace group TSO", | |
zap.String("member", kgm.tsoServiceID.ServiceAddr), | |
zap.Uint32("merge-target-id", mergeTargetID), | |
zap.Any("merge-list", mergeList), | |
zap.Uint32("merge-id", id), | |
zap.Time("ts", ts), | |
zap.Error(err)) | |
break | |
} | |
if ts.After(mergedTS) { | |
mergedTS = ts | |
} | |
} | |
if err != nil { | |
continue | |
} |
Since the err
in the loop is a local variable, so the check at line 1382 will always be false.
Metadata
Metadata
Assignees
Labels
affects-7.5This bug affects the 7.5.x(LTS) versions.This bug affects the 7.5.x(LTS) versions.affects-8.1This bug affects the 8.1.x(LTS) versions.This bug affects the 8.1.x(LTS) versions.affects-8.3component/keyspaceKey space.Key space.component/tsoTimestamp Oracle.Timestamp Oracle.severity/criticaltype/bugThe issue is confirmed as a bug.The issue is confirmed as a bug.
Type
Projects
Status
Closed