Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

etcd key path is so difficult to read #8582

Open
okJiang opened this issue Aug 28, 2024 · 0 comments · May be fixed by #8919
Open

etcd key path is so difficult to read #8582

okJiang opened this issue Aug 28, 2024 · 0 comments · May be fixed by #8919
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@okJiang
Copy link
Member

okJiang commented Aug 28, 2024

Enhancement Task

update them to string rather than several function nesting. In this case it is straightforward to use the function to generate the final key path yet, without any change in usage, but we can clearly see the format of each path.

https://github.com/tikv/pd/blob/master/pkg/storage/endpoint/key_path.go
@okJiang okJiang added the type/enhancement The issue or PR belongs to an enhancement. label Aug 28, 2024
@okJiang okJiang mentioned this issue Nov 7, 2024
Merged
ti-chi-bot bot added a commit that referenced this issue Nov 25, 2024
@okJiang @ti-chi-bot
etcd/path: change leaderPath/dcLocationPath/memberPath/allocalIDPath …
19c54c8 
…to absolute path (#8789)

ref #8582

Signed-off-by: okJiang <819421878@qq.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@okJiang okJiang mentioned this issue Nov 27, 2024
Merged
ti-chi-bot bot pushed a commit that referenced this issue Dec 2, 2024
@okJiang
keypath: unify leader/primary path (#8859)
3cfd66f 
ref #8582

Signed-off-by: okJiang <819421878@qq.com>
@okJiang okJiang linked a pull request Dec 16, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

keypath: remove rootPath from storage and change all paths to absolute path okJiang/pd
1 participant
@okJiang