Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Region may not be removed in hot peer cache after merging #8698

Closed
rleungx opened this issue Oct 14, 2024 · 0 comments · Fixed by #8702
Closed

Region may not be removed in hot peer cache after merging #8698

rleungx opened this issue Oct 14, 2024 · 0 comments · Fixed by #8702
Labels
affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. severity/major type/bug The issue is confirmed as a bug.

Comments

@rleungx
Copy link
Member

rleungx commented Oct 14, 2024 •
edited
Loading

Bug Report

If the region is not completely cooled down and the merge happens, it might be left in the hot peer cache and never be cleaned up. The merged region will never send a heartbeat again, resulting in checkExpiredTask not working.
@rleungx rleungx added the type/bug The issue is confirmed as a bug. label Oct 14, 2024
@lhy1024 lhy1024 mentioned this issue Oct 14, 2024
Merged
@rleungx rleungx added affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. labels Oct 15, 2024
@ti-chi-bot ti-chi-bot bot closed this as completed in 20087e2 Oct 28, 2024
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue Oct 30, 2024
@lhy1024 @ti-chi-bot
This is an automated cherry-pick of tikv#8702
0830b68 
close tikv#8698

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this issue Oct 30, 2024
Merged
ti-chi-bot bot pushed a commit that referenced this issue Oct 31, 2024
@ti-chi-bot @lhy1024
statistics: add gc in hot peer cache (#8702) (#8750)
1de26e8 
close #8698

Signed-off-by: lhy1024 <admin@liudos.us>

Co-authored-by: lhy1024 <admin@liudos.us>
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue Dec 5, 2024
@lhy1024 @ti-chi-bot
This is an automated cherry-pick of tikv#8702
5d4817c 
close tikv#8698

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this issue Dec 5, 2024
Merged
ti-chi-bot bot added a commit that referenced this issue Dec 9, 2024
@ti-chi-bot @lhy1024 @ti-chi-bot
statistics: add gc in hot peer cache (#8702) (#8871)
c0645e1 
close #8698

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: lhy1024 <admin@liudos.us>

Co-authored-by: lhy1024 <liuhanyang@pingcap.com>
Co-authored-by: lhy1024 <admin@liudos.us>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue Dec 11, 2024
@lhy1024 @ti-chi-bot
This is an automated cherry-pick of tikv#8702
70bb1e1 
close tikv#8698

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this issue Dec 11, 2024
Merged
ti-chi-bot bot added a commit that referenced this issue Dec 12, 2024
@ti-chi-bot @lhy1024 @ti-chi-bot
statistics: add gc in hot peer cache (#8702) (#8897)
57fdd79 
close #8698

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: lhy1024 <admin@liudos.us>

Co-authored-by: lhy1024 <liuhanyang@pingcap.com>
Co-authored-by: lhy1024 <admin@liudos.us>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

statistics: add gc in hot peer cache lhy1024/pd
2 participants
@jebter @rleungx