Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource-control:deleted-resource group still appear in available RU pannel #8716

Closed
AndreMouche opened this issue Oct 16, 2024 · 2 comments · Fixed by #8722
Closed

resource-control:deleted-resource group still appear in available RU pannel #8716

AndreMouche opened this issue Oct 16, 2024 · 2 comments · Fixed by #8722
Labels
affects-8.1 This bug affects the 8.1.x(LTS) versions. difficulty/easy Easy task. severity/moderate type/bug The issue is confirmed as a bug.

Comments

@AndreMouche
Copy link
Member

AndreMouche commented Oct 16, 2024

removing iteam from availableRUCounter with three arguments maybe failed since it only have two lables

availableRUCounter.DeleteLabelValues(r.name, r.name, r.ruType)

availableRUCounter = prometheus.NewGaugeVec(
prometheus.GaugeOpts{
Namespace: namespace,
Subsystem: ruSubsystem,
Name: "available_ru",
Help: "Counter of the available RU for all resource groups.",
}, []string{resourceGroupNameLabel, newResourceGroupNameLabel})

This would cause the resource group that has already been deleted to still appear in the resource-control->resource unit->available RU pannel. even though the data is already 0, we expect it not to appear any more.

Copy link
Contributor

ti-chi-bot bot commented Oct 16, 2024

There are no type labels on this issue. Please add an appropriate label by using the following command:

  • /type <type-name>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the needs-type Indicates an issue requires a type label. label Oct 16, 2024
@AndreMouche AndreMouche added difficulty/easy Easy task. and removed needs-type Indicates an issue requires a type label. labels Oct 16, 2024
@AndreMouche AndreMouche changed the title resource-control:removing iteam from availableRUCounter with three arguments maybe failed since only have two lables resource-control:deleted-resource group still appear in available RU pannel Oct 16, 2024
@AndreMouche AndreMouche added the affects-8.1 This bug affects the 8.1.x(LTS) versions. label Oct 16, 2024
@okJiang
Copy link
Member

okJiang commented Oct 17, 2024

/type bug

@ti-chi-bot ti-chi-bot bot added the type/bug The issue is confirmed as a bug. label Oct 17, 2024
@ti-chi-bot ti-chi-bot bot closed this as completed in 41bd2cd Oct 18, 2024
ti-chi-bot bot added a commit that referenced this issue Dec 12, 2024
… in metrics (#8722) (#8899)

close #8716

resource-group: fix issue that the deleted resource group still appear in metrics

Signed-off-by: AndreMouche <AndreMouche@126.com>

Co-authored-by: AndreMouche <AndreMouche@126.com>
Co-authored-by: Shirly <AndreMouche@126.com>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-8.1 This bug affects the 8.1.x(LTS) versions. difficulty/easy Easy task. severity/moderate type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants