-
Notifications
You must be signed in to change notification settings - Fork 725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The watch leader loop should exit ASAP when etcd leader changes #8823
Labels
affects-5.4
This bug affects the 5.4.x(LTS) versions.
affects-6.1
This bug affects the 6.1.x(LTS) versions.
affects-6.5
This bug affects the 6.5.x(LTS) versions.
affects-7.1
This bug affects the 7.1.x(LTS) versions.
affects-7.5
This bug affects the 7.5.x(LTS) versions.
affects-8.1
This bug affects the 8.1.x(LTS) versions.
affects-8.5
This bug affects the 8.5.x(LTS) versions.
report/customer
Customers have encountered this bug.
severity/major
type/bug
The issue is confirmed as a bug.
Comments
ti-chi-bot
bot
added
may-affects-5.4
may-affects-6.1
may-affects-6.5
may-affects-7.1
may-affects-7.5
may-affects-8.1
may-affects-8.5
affects-6.5
This bug affects the 6.5.x(LTS) versions.
affects-8.5
This bug affects the 8.5.x(LTS) versions.
affects-8.1
This bug affects the 8.1.x(LTS) versions.
affects-7.5
This bug affects the 7.5.x(LTS) versions.
affects-7.1
This bug affects the 7.1.x(LTS) versions.
affects-6.1
This bug affects the 6.1.x(LTS) versions.
affects-5.4
This bug affects the 5.4.x(LTS) versions.
and removed
may-affects-6.5
may-affects-8.5
may-affects-8.1
may-affects-7.5
may-affects-7.1
may-affects-6.1
may-affects-5.4
labels
Nov 20, 2024
ti-chi-bot
pushed a commit
to ti-chi-bot/pd
that referenced
this issue
Nov 20, 2024
close tikv#8823 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot
pushed a commit
to ti-chi-bot/pd
that referenced
this issue
Nov 20, 2024
close tikv#8823 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot
pushed a commit
to ti-chi-bot/pd
that referenced
this issue
Nov 20, 2024
close tikv#8823 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot
pushed a commit
to ti-chi-bot/pd
that referenced
this issue
Nov 20, 2024
close tikv#8823 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
This was referenced Nov 20, 2024
ti-chi-bot
pushed a commit
to ti-chi-bot/pd
that referenced
this issue
Nov 20, 2024
close tikv#8823 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot
pushed a commit
to ti-chi-bot/pd
that referenced
this issue
Nov 20, 2024
close tikv#8823 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Merged
ti-chi-bot bot
pushed a commit
that referenced
this issue
Dec 6, 2024
ref #8823 Signed-off-by: Ryan Leung <rleungx@gmail.com>
rleungx
added a commit
to ti-chi-bot/pd
that referenced
this issue
Dec 6, 2024
ref tikv#8823 Signed-off-by: Ryan Leung <rleungx@gmail.com>
rleungx
added a commit
to rleungx/pd
that referenced
this issue
Dec 6, 2024
ref tikv#8823 Signed-off-by: Ryan Leung <rleungx@gmail.com>
rleungx
added a commit
to ti-chi-bot/pd
that referenced
this issue
Dec 11, 2024
ref tikv#8823 Signed-off-by: Ryan Leung <rleungx@gmail.com>
ti-chi-bot bot
added a commit
that referenced
this issue
Dec 11, 2024
close #8823 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> Signed-off-by: Ryan Leung <rleungx@gmail.com> Co-authored-by: Ryan Leung <rleungx@gmail.com> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
This was referenced Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
affects-5.4
This bug affects the 5.4.x(LTS) versions.
affects-6.1
This bug affects the 6.1.x(LTS) versions.
affects-6.5
This bug affects the 6.5.x(LTS) versions.
affects-7.1
This bug affects the 7.1.x(LTS) versions.
affects-7.5
This bug affects the 7.5.x(LTS) versions.
affects-8.1
This bug affects the 8.1.x(LTS) versions.
affects-8.5
This bug affects the 8.5.x(LTS) versions.
report/customer
Customers have encountered this bug.
severity/major
type/bug
The issue is confirmed as a bug.
Bug Report
pd/pkg/syncer/client.go
Lines 149 to 169 in 40fe83e
Right now, we use sleep to prevent retrying to sync with the leader too frequently. However, it will indeed affect the PD election time if the etcd leader changes. The follower must wait for 1s to exit the loop before starting the election. See both line 156 and line 168. We can use the context to make it exit ASAP.
Here is the case that slows down the leader election:
The text was updated successfully, but these errors were encountered: