Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pd client panics with "[tso] timestamp fallback" #8889

Closed
lhy1024 opened this issue Dec 10, 2024 · 2 comments · Fixed by #8885
Closed

pd client panics with "[tso] timestamp fallback" #8889

lhy1024 opened this issue Dec 10, 2024 · 2 comments · Fixed by #8885
Labels
affects-8.5 This bug affects the 8.5.x(LTS) versions. impact/panic severity/major type/bug The issue is confirmed as a bug.

Comments

@lhy1024
Copy link
Contributor

lhy1024 commented Dec 10, 2024

Bug Report

What did you do?

run jepson test

What did you expect to see?

no panic

What did you see instead?

pd client panics with "[tso] timestamp fallback"

What version of PD are you using (pd-server -V)?

8.5
@lhy1024 lhy1024 added the type/bug The issue is confirmed as a bug. label Dec 10, 2024
@lhy1024
Copy link
Contributor Author

lhy1024 commented Dec 10, 2024

more log and analysis：#8836 (comment)

@rleungx rleungx mentioned this issue Dec 10, 2024
Closed
@rleungx rleungx added affects-8.5 This bug affects the 8.5.x(LTS) versions. severity/major labels Dec 10, 2024
@lhy1024 lhy1024 mentioned this issue Dec 10, 2024
Merged
ti-chi-bot bot added a commit that referenced this issue Dec 10, 2024
@lhy1024 @ti-chi-bot
cluster: fix tso fallback due raft cluster did not stop tso service (…
0b757ce 
…part2) (#8885)

ref #8477, close #8889

Signed-off-by: lhy1024 <admin@liudos.us>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@ti-chi-bot ti-chi-bot mentioned this issue Dec 10, 2024
Merged
ti-chi-bot bot pushed a commit that referenced this issue Dec 10, 2024
@ti-chi-bot @lhy1024
cluster: fix tso fallback due raft cluster did not stop tso service (…
d190c0e 
…part2) (#8885) (#8890)

ref #8477, close #8889

Signed-off-by: lhy1024 <admin@liudos.us>

Co-authored-by: lhy1024 <admin@liudos.us>
@rleungx
Copy link
Member

rleungx commented Dec 12, 2024

The root cause is bootstrap will affect the TSO lifetime. After we decouple the TSO lifetime from the bootstrap process which remains the same as before, it works well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-8.5 This bug affects the 8.5.x(LTS) versions. impact/panic severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cluster: fix tso fallback due raft cluster did not stop tso service (part2) lhy1024/pd
3 participants
@jebter @lhy1024 @rleungx