*: add region option for random pick region #1005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Connor1996
reviewed
Mar 26, 2018
server/cache.go
Outdated
| @@ -279,10 +279,10 @@ func (c *clusterInfo) getRegions() []*core.RegionInfo { | |||
| return c.Regions.GetRegions() | |||
| } | |||
|
|
|||
| func (c *clusterInfo) randomRegion() *core.RegionInfo { | |||
| func (c *clusterInfo) randomRegion(ops ...core.RegionOption) *core.RegionInfo { | |||
|
Can we abstract 'has leader on store x' and 'has follower on store x' as options? |
disksing
reviewed
Mar 26, 2018
server/core/region.go
Outdated
| if len(region.DownPeers) > 0 || len(region.PendingPeers) > 0 { | ||
| return false | ||
| } | ||
| return true |
There was a problem hiding this comment.
return len(downPeers) == 0 && len(pendingPeers) == 0
Connor1996
reviewed
Mar 26, 2018
server/cache.go
Outdated
| @@ -324,17 +324,17 @@ func (c *clusterInfo) getStoreLeaderCount(storeID uint64) int { | |||
| } | |||
|
|
|||
| // RandLeaderRegion returns a random region that has leader on the store. | |||
| func (c *clusterInfo) RandLeaderRegion(storeID uint64) *core.RegionInfo { | |||
| func (c *clusterInfo) RandLeaderRegion(storeID uint64, ops ...core.RegionOption) *core.RegionInfo { | |||
server/cache.go
Outdated
| } | ||
|
|
||
| // RandFollowerRegion returns a random region that has a follower on the store. | ||
| func (c *clusterInfo) RandFollowerRegion(storeID uint64) *core.RegionInfo { | ||
| func (c *clusterInfo) RandFollowerRegion(storeID uint64, ops ...core.RegionOption) *core.RegionInfo { |
server/namespace_cluster.go
Outdated
| @@ -60,9 +60,9 @@ func (c *namespaceCluster) checkRegion(region *core.RegionInfo) bool { | |||
| const randRegionMaxRetry = 10 | |||
|
|
|||
| // RandFollowerRegion returns a random region that has a follower on the store. | |||
| func (c *namespaceCluster) RandFollowerRegion(storeID uint64) *core.RegionInfo { | |||
| func (c *namespaceCluster) RandFollowerRegion(storeID uint64, ops ...core.RegionOption) *core.RegionInfo { | |||
server/namespace_cluster.go
Outdated
| @@ -74,9 +74,9 @@ func (c *namespaceCluster) RandFollowerRegion(storeID uint64) *core.RegionInfo { | |||
| } | |||
|
|
|||
| // RandLeaderRegion returns a random region that has leader on the store. | |||
| func (c *namespaceCluster) RandLeaderRegion(storeID uint64) *core.RegionInfo { | |||
| func (c *namespaceCluster) RandLeaderRegion(storeID uint64, ops ...core.RegionOption) *core.RegionInfo { | |||
server/schedule/basic_cluster.go
Outdated
| @@ -146,13 +146,13 @@ func (bc *BasicCluster) UnblockStore(storeID uint64) { | |||
| } | |||
|
|
|||
| // RandFollowerRegion returns a random region that has a follower on the store. | |||
| func (bc *BasicCluster) RandFollowerRegion(storeID uint64) *core.RegionInfo { | |||
| return bc.Regions.RandFollowerRegion(storeID) | |||
| func (bc *BasicCluster) RandFollowerRegion(storeID uint64, ops ...core.RegionOption) *core.RegionInfo { | |||
server/schedule/basic_cluster.go
Outdated
| } | ||
|
|
||
| // RandLeaderRegion returns a random region that has leader on the store. | ||
| func (bc *BasicCluster) RandLeaderRegion(storeID uint64) *core.RegionInfo { | ||
| return bc.Regions.RandLeaderRegion(storeID) | ||
| func (bc *BasicCluster) RandLeaderRegion(storeID uint64, ops ...core.RegionOption) *core.RegionInfo { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
same as the title.