pdctl: use cobra print function #1313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
how about the new output, the same as origin? |
disksing
approved these changes
Nov 8, 2018
|
@siddontang Yes, the same as before. |
nolouch
approved these changes
Nov 8, 2018
rleungx
added a commit
to rleungx/pd
that referenced
this pull request
Nov 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Cobra has its own print functions which can be used to specify the output. In addition, we can use it to write some
pd-ctltests.What is changed and how it works?
This PR replaces all standard print functions in
pd-ctlwithcobra's print functions.Check List
Tests