Add max wait count for transfer leader operator. #147
Conversation
|
why not handling directly in LeaderTransfer? |
qiuyesuifeng
force-pushed
the
qiuyesuifeng/leader-transfer-operator
branch
from
491ff11 to
3132e46
Compare
qiuyesuifeng
changed the title
|
@siddontang Agreed, PTAL. |
| @@ -176,6 +176,8 @@ func (co *ChangePeerOperator) Do(region *metapb.Region, leader *metapb.Peer) (bo | |||
|
|
|||
| // TransferLeaderOperator is used to do leader transfer. | |||
| type TransferLeaderOperator struct { | |||
| mustSuc bool | |||
|
LGTM |
|
LGTM |
|
@shenli @siddontang |
| newLeader: newLeader, | ||
| oldLeader: oldLeader, | ||
| newLeader: newLeader, | ||
| count: 0, |
There was a problem hiding this comment.
The default value of count is already zero.
There was a problem hiding this comment.
Yes, it is a variable like index, we should update it in Do function.
There was a problem hiding this comment.
count and maxWaitCount confuse me.
you can initialize count as waitCount and then use lto.count < 0 lt.count-- to check.
There was a problem hiding this comment.
Seems not, we must store the origin maxWaitCount to make sure the first time we return the transfer leader response.
If we only use count, then we cannot distinct it.
|
LGTM |
qiuyesuifeng
changed the title
* fix watch keyspace test case Signed-off-by: ystaticy <y_static_y@sina.com>
No description provided.