Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: set timeout for MoveLeader #1537

Closed
wants to merge 2 commits into from

Conversation

disksing
Copy link
Contributor

Signed-off-by: disksing i@disksing.com

What problem does this PR solve?

When multiple PDs calls MoveLeader, one will succeed and others will block in MoveLeader function.

What is changed and how it works?

Add timeout when calling MoveLeader.
Cherry-pick #1533

Check List

Tests

  • Integration test

Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
@disksing
Copy link
Contributor Author

/run-all-tests tidb=release-2.0 tikv=release-2.0 tidb-test=release-2.0

@disksing
Copy link
Contributor Author

😢 2.0 uses etcd's gofail, now it cannot run tests.

@siddontang
Copy link
Contributor

seem we don't care 2.0 now

@disksing
Copy link
Contributor Author

release-2.0 is not maintained any more. Close it for now. We can reopen it if we want to release a new 2.0.x version later.

@disksing disksing closed this May 16, 2019
@disksing disksing deleted the move-leader-2.0 branch May 16, 2019 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants