statistics, schedulers: split hot cache to each store #1641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolouch
force-pushed
the
hot-sche-to-store
branch
from
3136d89 to
e347d3a
Compare
Signed-off-by: nolouch <nolouch@gmail.com>
nolouch
force-pushed
the
hot-sche-to-store
branch
from
e347d3a to
b262392
Compare
shafreeck
suggested changes
Jul 18, 2019
server/statistics/hot_cache.go
Outdated
| hotRegionThreshold := calculateWriteHotThreshold(stats) | ||
| return w.isNeedUpdateStatCache(region, WrittenBytesPerSec, hotRegionThreshold, value, WriteFlow) | ||
| for _, storeID := range storeIDs { | ||
| WrittenBytesPerSec = uint64(float64(region.GetBytesWritten()) / float64(RegionHeartBeatReportInterval)) |
There was a problem hiding this comment.
This can be calculated before the for loop
Signed-off-by: nolouch <nolouch@gmail.com>
Luffbee
reviewed
Jul 25, 2019
Luffbee
reviewed
Jul 26, 2019
Signed-off-by: nolouch <nolouch@gmail.com>
nolouch
changed the title
Luffbee
reviewed
Jul 26, 2019
Signed-off-by: nolouch <nolouch@gmail.com>
Signed-off-by: nolouch <nolouch@gmail.com>
Signed-off-by: nolouch <nolouch@gmail.com>
Signed-off-by: nolouch <nolouch@gmail.com>
Signed-off-by: nolouch <nolouch@gmail.com>
shafreeck
suggested changes
Aug 1, 2019
Signed-off-by: nolouch <nolouch@gmail.com>
Signed-off-by: nolouch <nolouch@gmail.com>
Signed-off-by: nolouch <nolouch@gmail.com>
|
PTAL @Luffbee @jiyingtk @shafreeck |
Luffbee
reviewed
Aug 2, 2019
|
@shafreeck Usually a metric traces a stable object, too much region may affect the performance. |
rleungx
reviewed
Aug 2, 2019
Signed-off-by: nolouch <nolouch@gmail.com>
|
PTAL @rleungx @shafreeck |
rleungx
reviewed
Aug 5, 2019
Signed-off-by: nolouch <nolouch@gmail.com>
rleungx
approved these changes
Aug 5, 2019
|
PTAL @shafreeck @Luffbee |
Luffbee
approved these changes
Aug 6, 2019
shafreeck
approved these changes
Aug 6, 2019
This was referenced Jan 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Our concert about hotspot should the
hot storethen thehot regionmore reasonable.What is changed and how it works?
hot cacheas a statistic for each store.Check List
Tests