Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdctl: add success response (#1600) #1685

Merged
merged 1 commit into from
Aug 19, 2019

Conversation

disksing
Copy link
Contributor

What problem does this PR solve?

Some pd-ctl commands do not have any output.

What is changed and how it works?

Show "Success!" like other commands.

Check List

Tests

  • Unit test
  • Integration test

@nolouch nolouch added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. labels Aug 19, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Aug 19, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Aug 19, 2019

@disksing merge failed.

@disksing
Copy link
Contributor Author

/run-all-tests tidb=release-3.0 tikv=release-3.0 tidb-test=release-3.0

@disksing
Copy link
Contributor Author

Travis CI failed due to VM out of memory. Merging.

@disksing disksing merged commit afba07a into tikv:release-3.0 Aug 19, 2019
@disksing disksing deleted the cherry-pick branch August 19, 2019 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants