Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: cleanup lint tools #1956

Merged
merged 2 commits into from
Nov 19, 2019
Merged

*: cleanup lint tools #1956

merged 2 commits into from
Nov 19, 2019

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Nov 19, 2019

What problem does this PR solve?

Just clean up lint tools.

What is changed and how it works?

This PR enables golangci-lint default tools except errcheck.

Check List

Tests

  • Unit test

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx rleungx requested review from lhy1024 and nolouch November 19, 2019 13:20
@rleungx rleungx added the type/enhancement The issue or PR belongs to an enhancement. label Nov 19, 2019
@codecov-io
Copy link

Codecov Report

Merging #1956 into master will increase coverage by 0.2%.
The diff coverage is 81.81%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1956     +/-   ##
=========================================
+ Coverage   77.86%   78.06%   +0.2%     
=========================================
  Files         170      170             
  Lines       16879    16874      -5     
=========================================
+ Hits        13142    13172     +30     
+ Misses       2714     2687     -27     
+ Partials     1023     1015      -8
Impacted Files Coverage Δ
server/schedulers/scatter_range.go 81.29% <ø> (ø) ⬆️
pkg/btree/btree.go 87.65% <ø> (+1.5%) ⬆️
server/testutil.go 88% <0%> (-3.67%) ⬇️
pkg/mock/mockhbstream/mockhbstream.go 86.11% <100%> (-0.38%) ⬇️
tools/pd-analysis/analysis/parse_log.go 37.03% <100%> (ø) ⬆️
server/schedulers/utils.go 87.8% <100%> (ø) ⬆️
server/core/region.go 90.18% <100%> (+0.37%) ⬆️
server/schedulers/hot_region.go 88.74% <100%> (ø) ⬆️
server/schedule/scheduler.go 69.76% <100%> (ø) ⬆️
server/kv/etcd_kv.go 75.32% <0%> (-6.5%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c0c102...ea43015. Read the comment docs.

@nolouch nolouch added the status/can-merge Indicates a PR has been approved by a committer. label Nov 19, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 19, 2019

/run-all-tests

@sre-bot sre-bot merged commit c71ec95 into tikv:master Nov 19, 2019
@rleungx rleungx deleted the cleanup-lint branch November 20, 2019 02:27
@rleungx
Copy link
Member Author

rleungx commented Nov 20, 2019

Once #1919 is fixed. We can enable errcheck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants