Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: enable etcd api v2 #2091

Merged
merged 1 commit into from
Jan 9, 2020
Merged

config: enable etcd api v2 #2091

merged 1 commit into from
Jan 9, 2020

Conversation

nolouch
Copy link
Contributor

@nolouch nolouch commented Jan 9, 2020

Signed-off-by: nolouch nolouch@gmail.com

What problem does this PR solve?

tiflash use v2 API.

What is changed and how it works?

enable v2 API.

Check List

Tests

  • Unit test

Signed-off-by: nolouch <nolouch@gmail.com>
@nolouch nolouch added this to the v4.0.0-beta milestone Jan 9, 2020
@lhy1024 lhy1024 added the component/config Configuration logic. label Jan 9, 2020
@codecov-io
Copy link

Codecov Report

Merging #2091 into master will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2091      +/-   ##
==========================================
+ Coverage   76.88%   76.96%   +0.07%     
==========================================
  Files         193      193              
  Lines       19419    19420       +1     
==========================================
+ Hits        14931    14946      +15     
+ Misses       3358     3350       -8     
+ Partials     1130     1124       -6
Impacted Files Coverage Δ
server/config/config.go 83.45% <100%> (+0.88%) ⬆️
server/schedulers/shuffle_hot_region.go 64.58% <0%> (-5.21%) ⬇️
server/region_syncer/client.go 77.1% <0%> (-4.82%) ⬇️
server/schedulers/random_merge.go 60.71% <0%> (-3.58%) ⬇️
server/schedule/operator_controller.go 82.35% <0%> (+0.17%) ⬆️
server/grpc_service.go 57.88% <0%> (+0.21%) ⬆️
client/client.go 69% <0%> (+0.53%) ⬆️
server/server.go 82.89% <0%> (+0.56%) ⬆️
server/cluster/coordinator.go 78.39% <0%> (+0.83%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c68b37e...761c73f. Read the comment docs.

Copy link
Member

@rleungx rleungx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhy1024
Copy link
Contributor

lhy1024 commented Jan 9, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 9, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Jan 9, 2020

/run-all-tests

@sre-bot sre-bot merged commit d9436bc into tikv:master Jan 9, 2020
@nolouch nolouch deleted the use-v2 branch January 9, 2020 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/config Configuration logic. status/can-merge Indicates a PR has been approved by a committer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants