Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: remove unnecessary executable permissions #2095

Merged
merged 1 commit into from
Jan 14, 2020

Conversation

Luffbee
Copy link
Contributor

@Luffbee Luffbee commented Jan 14, 2020

What problem does this PR solve?

Some *.go files have executable permission. (Introduced by PR #1902)

What is changed and how it works?

Remove unnecessary executable permissions.

Check List

Tests

  • No code

@Luffbee Luffbee added the type/refactor The issue belongs to a refactor work. label Jan 14, 2020
@codecov-io
Copy link

Codecov Report

Merging #2095 into master will decrease coverage by 0.43%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2095      +/-   ##
==========================================
- Coverage   77.41%   76.97%   -0.44%     
==========================================
  Files         193      193              
  Lines       19573    19573              
==========================================
- Hits        15152    15067      -85     
- Misses       3317     3369      +52     
- Partials     1104     1137      +33
Impacted Files Coverage Δ
server/server.go 82.33% <ø> (-2.07%) ⬇️
server/cluster/cluster.go 81.31% <ø> (ø) ⬆️
server/kv/etcd_kv.go 72.72% <0%> (-11.69%) ⬇️
pkg/etcdutil/etcdutil.go 78.26% <0%> (-10.15%) ⬇️
pkg/metricutil/metricutil.go 86.11% <0%> (-8.34%) ⬇️
server/heartbeat_streams.go 67% <0%> (-6%) ⬇️
server/tso/tso.go 77.37% <0%> (-5.84%) ⬇️
server/member/leader.go 76.53% <0%> (-5.62%) ⬇️
server/schedulers/random_merge.go 60.71% <0%> (-3.58%) ⬇️
server/grpc_service.go 56.7% <0%> (-2.82%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49f194a...ad03b95. Read the comment docs.

Copy link
Member

@rleungx rleungx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@disksing
Copy link
Contributor

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 14, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Jan 14, 2020

/run-all-tests

@sre-bot sre-bot merged commit d4c196e into tikv:master Jan 14, 2020
@Luffbee Luffbee deleted the fix-file-permission branch January 27, 2020 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. type/refactor The issue belongs to a refactor work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants