schedulers: add role config to shuffleRegionScheduler #2219
Conversation
Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
disksing
changed the title
|
/run-test |
disksing
added
the
needs-cherry-pick-release-3.1
|
|
||
| func (conf *shuffleRegionSchedulerConfig) ServeHTTP(w http.ResponseWriter, r *http.Request) { | ||
| router := mux.NewRouter() | ||
| router.HandleFunc("/roles", conf.handleGetRoles).Methods("GET") |
There was a problem hiding this comment.
Is this the root path of PD's API? Maybe add the PD API prefix is better?
There was a problem hiding this comment.
no, it is a sub router to be registered under scheduler_config/shuffle-region-scheduler/.
| if cluster.IsPlacementRulesEnabled() { | ||
| scoreGuard = filter.NewRuleFitFilter(s.GetName(), cluster, region, oldPeer.GetStoreId()) | ||
| } else { | ||
| scoreGuard = filter.NewDistinctScoreFilter(s.GetName(), cluster.GetLocationLabels(), cluster.GetRegionStores(region), cluster.GetStore(oldPeer.GetStoreId())) |
There was a problem hiding this comment.
Is it different from the original behavior?
There was a problem hiding this comment.
yes, different. Priviously it does not consider any constraints.
| roles = append(roles, f) | ||
| } | ||
| } | ||
| b, _ := json.Marshal(roles) |
There was a problem hiding this comment.
Do we need to handle this error?
There was a problem hiding this comment.
it should not return any error as it only contains basic types.
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
|
@disksing merge failed. |
|
/run-test |
|
/merge |
|
/run-all-tests |
|
@disksing merge failed. |
|
CI failure cased by #2231 |
|
/merge |
|
/run-all-tests |
|
@disksing merge failed. |
|
/merge |
|
/run-all-tests |
|
cherry pick to release-3.1 failed |
Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
What problem does this PR solve?
Fix #2177
What is changed and how it works?
Add role configuration to shuffle-region-scheduler.
Use it to balance learners:
1. add shuffle-region-scheduler
or
2. config roles
or
Check List
Tests
Code changes
Related changes