*: add engine filter to exclude special stores #2426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nolouch <nolouch@gmail.com>
|
No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md |
|
/run-all-tests |
|
/rebuild |
nolouch
added
the
needs-cherry-pick-release-4.0
HunDunDM
reviewed
May 18, 2020
server/schedule/filter/filters.go
Outdated
| } | ||
|
|
||
| // NewEngineFilter creates a filter that filters store for special engine. | ||
| func NewEngineFilter(scope string, allowUses ...string) Filter { |
There was a problem hiding this comment.
Can constraint.Values be specified directly in the constructor?
There was a problem hiding this comment.
I have adds some comments.
Signed-off-by: nolouch <nolouch@gmail.com>
nolouch
added
type/bug
Signed-off-by: nolouch <nolouch@gmail.com>
lhy1024
reviewed
May 21, 2020
rleungx
reviewed
May 21, 2020
server/schedule/filter/filters.go
Outdated
| // NewEngineFilter creates a filter that filters out default engine stores. | ||
| // By default, all stores that are not marked with a special engine will be filtered out. | ||
| // Specify the special engine label if you want to include the special stores. | ||
| func NewEngineFilter(scope string, allowSpeicalEngines ...string) Filter { |
There was a problem hiding this comment.
There is too much inverse logic and it's hard to understand.
There was a problem hiding this comment.
any suggestion? It is same as SpecailUseFilter
Signed-off-by: nolouch <nolouch@gmail.com>
|
/rebuild |
Signed-off-by: nolouch <nolouch@gmail.com>
|
/approve |
|
/approve |
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
rleungx
approved these changes
May 22, 2020
|
/merge |
|
/run-all-tests |
|
@nolouch merge failed. |
|
/rebuild |
|
/merge |
|
/run-all-tests |
|
@nolouch merge failed. |
|
/merge |
|
/run-all-tests |
|
It's about dashboard, merge it firstly. |
|
cherry pick to release-4.0 in PR #2447 |
jebter
pushed a commit
that referenced
this pull request
May 25, 2020
* *: add engine filter Signed-off-by: nolouch <nolouch@gmail.com> * add comments Signed-off-by: nolouch <nolouch@gmail.com> * address comments Signed-off-by: nolouch <nolouch@gmail.com> * address comments Signed-off-by: nolouch <nolouch@gmail.com> * address comments Signed-off-by: nolouch <nolouch@gmail.com> Co-authored-by: nolouch <nolouch@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: nolouch nolouch@gmail.com
What problem does this PR solve?
Fix #2423
AvaiableStore()always returns flash nodes, so the tikv nodes cannot be used.Release note
presplitnot work within tiflash cluster.