-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apiutil: refine the log errs in apiutil (#2722) #2912
Merged
ti-srebot
merged 2 commits into
tikv:release-4.0
from
ti-srebot:release-4.0-a6cb51b0a720
Sep 7, 2020
Merged
apiutil: refine the log errs in apiutil (#2722) #2912
ti-srebot
merged 2 commits into
tikv:release-4.0
from
ti-srebot:release-4.0-a6cb51b0a720
Sep 7, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-srebot
added
component/api
HTTP API.
component/log
Log.
contribution
This PR is from a community contributor.
require-LGT1
Indicates that the PR requires an LGTM.
status/LGT1
Indicates that a PR has LGTM 1.
type/cherry-pick
labels
Sep 7, 2020
Signed-off-by: Ryan Leung <rleungx@gmail.com>
rleungx
force-pushed
the
release-4.0-a6cb51b0a720
branch
from
September 7, 2020 08:46
00e632d
to
ad66f48
Compare
LGTM |
@howardlau1999,Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments.See the corresponding SIG page for more information. Related SIG: scheduling(slack). |
Yisaer
approved these changes
Sep 7, 2020
HunDunDM
approved these changes
Sep 7, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ti-srebot
added
status/LGT2
Indicates that a PR has LGTM 2.
and removed
status/LGT1
Indicates that a PR has LGTM 1.
labels
Sep 7, 2020
/merge |
ti-srebot
added
the
status/can-merge
Indicates a PR has been approved by a committer.
label
Sep 7, 2020
/run-all-tests |
This was referenced Sep 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component/api
HTTP API.
component/log
Log.
contribution
This PR is from a community contributor.
require-LGT1
Indicates that the PR requires an LGTM.
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT2
Indicates that a PR has LGTM 2.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #2722 to release-4.0
Signed-off-by: JmPotato ghzpotato@gmail.com
What problem does this PR solve?
To solve #2704
What is changed and how it works?
Check List
Tests
Release note