Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: minor fix for log refinement (#2916) #2918

Merged
merged 1 commit into from
Sep 7, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #2916 to release-4.0


What problem does this PR solve?

Related to #2704.

What is changed and how it works?

This PR fixes some logs which are not consistent by mistake.

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

Release note

@ti-srebot ti-srebot added component/log Log. require-LGT1 Indicates that the PR requires an LGTM. status/LGT1 Indicates that a PR has LGTM 1. type/cherry-pick labels Sep 7, 2020
@ti-srebot ti-srebot added this to the v4.0.6 milestone Sep 7, 2020
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Copy link
Contributor

@Yisaer Yisaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 7, 2020
@lhy1024
Copy link
Contributor

lhy1024 commented Sep 7, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 7, 2020
@rleungx
Copy link
Member

rleungx commented Sep 7, 2020

/merge

@ti-srebot
Copy link
Contributor Author

/run-all-tests

Copy link
Member

@HunDunDM HunDunDM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT3 The PR has already had 3 LGTM. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Sep 7, 2020
@codecov
Copy link

codecov bot commented Sep 7, 2020

Codecov Report

Merging #2918 into release-4.0 will increase coverage by 0.04%.
The diff coverage is 16.66%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-4.0    #2918      +/-   ##
===============================================
+ Coverage        77.26%   77.30%   +0.04%     
===============================================
  Files              209      209              
  Lines            22850    22850              
===============================================
+ Hits             17655    17665      +10     
+ Misses            3855     3842      -13     
- Partials          1340     1343       +3     
Impacted Files Coverage Δ
server/cluster/cluster.go 80.89% <0.00%> (-0.41%) ⬇️
server/region_syncer/client.go 80.29% <0.00%> (ø)
server/schedule/checker/replica_checker.go 83.43% <0.00%> (ø)
server/tso/tso.go 79.74% <0.00%> (-1.27%) ⬇️
server/server.go 76.18% <50.00%> (-0.89%) ⬇️
pkg/etcdutil/etcdutil.go 86.30% <0.00%> (-2.74%) ⬇️
server/core/storage.go 72.86% <0.00%> (-0.78%) ⬇️
server/grpc_service.go 59.77% <0.00%> (-0.76%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1d3230...5becb79. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/log Log. require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT3 The PR has already had 3 LGTM.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants