Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

schedule: add joint state checker #2952

Merged
merged 5 commits into from
Sep 16, 2020
Merged

schedule: add joint state checker #2952

merged 5 commits into from
Sep 16, 2020

Conversation

HunDunDM
Copy link
Member

Signed-off-by: Zheng Xiangsheng hundundm@gmail.com

What problem does this PR solve?

This is a child PR of #2886

For details, please refer to #2860

What is changed and how it works?

  • schedule: add joint state checker

Check List

Tests

  • Unit test

Release note

  • support use joint consensus to change region peers

@HunDunDM HunDunDM added the component/schedule Scheduling logic. label Sep 14, 2020
@HunDunDM HunDunDM self-assigned this Sep 14, 2020
@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 14, 2020
Yisaer
Yisaer reviewed Sep 14, 2020
View reviewed changes
Copy link
Contributor

@Yisaer Yisaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

server/schedule/checker/joint_state_checker_test.go Outdated Show resolved Hide resolved
@HunDunDM HunDunDM mentioned this pull request Sep 14, 2020
Closed
37 tasks
@lhy1024 lhy1024 self-requested a review September 16, 2020 04:34
Yisaer
Yisaer approved these changes Sep 16, 2020
View reviewed changes
Copy link
Contributor

@Yisaer Yisaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Sep 16, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Sep 16, 2020
@HunDunDM
schedule: add joint state checker
9331db2 
Signed-off-by: Zheng Xiangsheng <hundundm@gmail.com>
@HunDunDM
refine test
60a419b 
Signed-off-by: Zheng Xiangsheng <hundundm@gmail.com>
@HunDunDM
set high priority
de0fdec 
Signed-off-by: Zheng Xiangsheng <hundundm@gmail.com>
@HunDunDM
add metrics
86e09ae 
Signed-off-by: Zheng Xiangsheng <hundundm@gmail.com>
@HunDunDM
refine test
89403a8 
Signed-off-by: Zheng Xiangsheng <hundundm@gmail.com>
nolouch
nolouch reviewed Sep 16, 2020
View reviewed changes
Copy link
Contributor

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT3 The PR has already had 3 LGTM. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Sep 16, 2020
@HunDunDM
Copy link
Member Author

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 16, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit c05ef6f into tikv:master Sep 16, 2020
@HunDunDM HunDunDM deleted the joint/checker branch September 16, 2020 06:39
HunDunDM added a commit to HunDunDM/pd that referenced this pull request Sep 16, 2020
@HunDunDM
schedule: add joint state checker (tikv#2952)
9247374 
Signed-off-by: Zheng Xiangsheng <hundundm@gmail.com>
# Conflicts:
#	server/schedule/checker_controller.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rleungx rleungx rleungx left review comments

@nolouch nolouch nolouch left review comments

@ti-srebot ti-srebot ti-srebot approved these changes

@lhy1024 lhy1024 lhy1024 approved these changes

@Yisaer Yisaer Yisaer approved these changes

Assignees

@HunDunDM HunDunDM

Labels
component/schedule Scheduling logic. status/can-merge Indicates a PR has been approved by a committer. status/LGT3 The PR has already had 3 LGTM.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@HunDunDM @ti-srebot @nolouch @Yisaer @lhy1024 @rleungx