Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: change log level for the stale region when loading #3064

Merged
merged 1 commit into from
Oct 13, 2020

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Oct 12, 2020

What problem does this PR solve?

Related to #2427, but for release-3.0

What is changed and how it works?

This PR changes the log level of the stale region when loading.

Check List

Tests

  • Unit test

Release note

  • Change the log level of the stale region when loading regions

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx rleungx changed the title change log level for the stale region when loading server: change log level for the stale region when loading Oct 12, 2020
@rleungx rleungx added this to the v3.0.20 milestone Oct 12, 2020
@rleungx rleungx added the component/log Log. label Oct 12, 2020
@codecov
Copy link

codecov bot commented Oct 12, 2020

Codecov Report

Merging #3064 into release-3.0 will decrease coverage by 2.90%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-3.0    #3064      +/-   ##
===============================================
- Coverage        69.92%   67.02%   -2.91%     
===============================================
  Files              171      171              
  Lines            16980    14333    -2647     
===============================================
- Hits             11873     9606    -2267     
+ Misses            4138     3770     -368     
+ Partials           969      957      -12     
Impacted Files Coverage Δ
server/cluster_info.go 86.76% <100.00%> (-1.63%) ⬇️
pkg/etcdutil/etcdutil.go 83.33% <0.00%> (-12.02%) ⬇️
server/schedule/scheduler.go 55.55% <0.00%> (-11.12%) ⬇️
server/schedulers/base_scheduler.go 53.33% <0.00%> (-9.83%) ⬇️
server/util.go 65.67% <0.00%> (-9.49%) ⬇️
server/tso.go 74.41% <0.00%> (-9.09%) ⬇️
server/api/cluster.go 66.66% <0.00%> (-8.34%) ⬇️
tools/pd-ctl/pdctl/command/cluster_command.go 66.66% <0.00%> (-8.34%) ⬇️
server/namespace/namespace.go 36.84% <0.00%> (-8.32%) ⬇️
...ls/pd-ctl/pdctl/command/table_namespace_command.go 52.17% <0.00%> (-7.83%) ⬇️
... and 162 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8e0a36...2d56e92. Read the comment docs.

Copy link
Member

@HunDunDM HunDunDM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 12, 2020
@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Oct 13, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Oct 13, 2020
@HunDunDM
Copy link
Member

/run-all-tests

@ti-srebot ti-srebot added status/LGT3 The PR has already had 3 LGTM. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Oct 13, 2020
@HunDunDM HunDunDM merged commit 155e8ef into tikv:release-3.0 Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/log Log. status/LGT3 The PR has already had 3 LGTM.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants