Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: update leader when peer url updates #3319

Merged
merged 3 commits into from
Jan 4, 2021

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Dec 31, 2020

What problem does this PR solve?

Close #3317

What is changed and how it works?

When returning the result of member, use the latest information from etcd

Check List

Tests

  • Unit test

Related changes

Release note

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx rleungx added component/api HTTP API. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Dec 31, 2020
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 31, 2020
@codecov
Copy link

codecov bot commented Dec 31, 2020

Codecov Report

Merging #3319 (20a6923) into master (ee0045a) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3319      +/-   ##
==========================================
+ Coverage   74.64%   74.72%   +0.08%     
==========================================
  Files         243      243              
  Lines       23136    23140       +4     
==========================================
+ Hits        17270    17292      +22     
+ Misses       4288     4269      -19     
- Partials     1578     1579       +1     
Flag Coverage Δ
unittests 74.72% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/grpc_service.go 56.17% <100.00%> (+1.49%) ⬆️
server/schedule/region_scatterer.go 80.61% <0.00%> (-3.58%) ⬇️
server/tso/local_allocator.go 78.78% <0.00%> (-3.04%) ⬇️
server/handler.go 42.75% <0.00%> (-0.50%) ⬇️
client/client.go 64.93% <0.00%> (-0.38%) ⬇️
server/tso/allocator_manager.go 75.45% <0.00%> (+0.40%) ⬆️
server/config/persist_options.go 92.12% <0.00%> (+0.78%) ⬆️
pkg/btree/btree.go 86.26% <0.00%> (+0.96%) ⬆️
server/server.go 73.73% <0.00%> (+1.26%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee0045a...20a6923. Read the comment docs.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 3, 2021
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx rleungx removed the status/DNM label Jan 4, 2021
Copy link
Contributor

@Yisaer Yisaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 4, 2021
@Yisaer
Copy link
Contributor

Yisaer commented Jan 4, 2021

/merge

@ti-chi-bot
Copy link
Member

@Yisaer: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/ti-community-prow repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b0e8c0c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 4, 2021
@ti-chi-bot
Copy link
Member

@rleungx: Your PR has out-of-dated, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/ti-community-prow repository.

@ti-chi-bot ti-chi-bot merged commit a00f33a into tikv:master Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/api HTTP API. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update PD member peer-URL when it was changed
4 participants