Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dashboard: update to v2021.03.12.1 (#3468) #3469

Merged
merged 2 commits into from
May 10, 2021

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Mar 12, 2021

cherry-pick #3468 to release-4.0
You can switch your code base to this Pull Request by using git-extras:

# In pd repo:
git pr https://github.com/tikv/pd/pull/3469

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/pd.git pr/3469:release-4.0-0b7e2e85a8e9

Signed-off-by: HunDunDM hundundm@gmail.com

related #3021

What problem does this PR solve?

  • dashboard: update to v2021.03.12.1

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Related changes

  • Need to cherry-pick to the release branch

Release note

  • dashboard: update to v2021.03.12.1

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-srebot ti-srebot added component/visualization Visualization. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick labels Mar 12, 2021
@ti-srebot ti-srebot added this to the v4.0.12 milestone Mar 12, 2021
@ti-chi-bot ti-chi-bot requested a review from HunDunDM March 12, 2021 09:20
@ti-srebot
Copy link
Contributor Author

@HunDunDM you're already a collaborator in bot's repo.

@HunDunDM HunDunDM modified the milestones: v4.0.12, v4.0.13 Mar 12, 2021
@rleungx rleungx added type/cherry-pick-for-release-4.0 The PR belongs to release-4.0 cherry pick. and removed type/cherry-pick-for-release-1.0 labels Apr 25, 2021
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label May 10, 2021
Signed-off-by: HunDunDM <hundundm@gmail.com>
@HunDunDM HunDunDM force-pushed the release-4.0-0b7e2e85a8e9 branch from 5d0c600 to 23ddb10 Compare May 10, 2021 08:20
@HunDunDM
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

@HunDunDM: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 23ddb10

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 10, 2021
@codecov
Copy link

codecov bot commented May 10, 2021

Codecov Report

Merging #3469 (0c09fe7) into release-4.0 (f1b3f49) will decrease coverage by 0.03%.
The diff coverage is 50.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-4.0    #3469      +/-   ##
===============================================
- Coverage        74.75%   74.71%   -0.04%     
===============================================
  Files              210      210              
  Lines            19831    19833       +2     
===============================================
- Hits             14824    14818       -6     
- Misses            3673     3674       +1     
- Partials          1334     1341       +7     
Flag Coverage Δ
unittests 74.71% <50.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/dashboard/adapter/config.go 62.50% <ø> (ø)
pkg/dashboard/adapter/redirector.go 93.33% <ø> (ø)
pkg/dashboard/dashboard.go 89.74% <ø> (ø)
pkg/dashboard/keyvisual/input/core.go 33.33% <ø> (ø)
pkg/dashboard/keyvisual/keyvisual.go 100.00% <ø> (ø)
pkg/dashboard/uiserver/embedded_assets_rewriter.go 100.00% <ø> (ø)
pkg/dashboard/adapter/manager.go 79.78% <50.00%> (-1.74%) ⬇️
server/tso/tso.go 77.53% <0.00%> (-2.90%) ⬇️
server/server.go 73.34% <0.00%> (-1.00%) ⬇️
server/core/storage.go 67.53% <0.00%> (-0.87%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1b3f49...0c09fe7. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 15 Code Smells

No Coverage information No Coverage information
2.9% 2.9% Duplication

@HunDunDM
Copy link
Member

/run-all-tests

@ti-chi-bot ti-chi-bot merged commit 5d12297 into tikv:release-4.0 May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. component/visualization Visualization. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-4.0 The PR belongs to release-4.0 cherry pick.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants