-
Notifications
You must be signed in to change notification settings - Fork 727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
checker: priority to fix orphan peers #3522
Conversation
need any test? |
basically LGTM except for lack of tests. |
Signed-off-by: nolouch <nolouch@gmail.com>
Signed-off-by: nolouch <nolouch@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #3522 +/- ##
==========================================
+ Coverage 74.56% 74.61% +0.04%
==========================================
Files 245 245
Lines 24068 24068
==========================================
+ Hits 17947 17958 +11
+ Misses 4509 4504 -5
+ Partials 1612 1606 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
@nolouch: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 4737707
|
SonarCloud Quality Gate failed. 0 Bugs No Coverage information |
/build |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-4.0 in PR #3529 |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-5.0 in PR #3530 |
What problem does this PR solve?
ref #3521
the problem is when offline a store, we may add learner multiple times if the operator is timeout.
What is changed and how it works?
Check List
Tests
Related changes
pingcap/docs
/pingcap/docs-cn
:pingcap/tidb-ansible
:Release note