Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checker: priority to fix orphan peers #3522

Merged
merged 3 commits into from
Mar 25, 2021
Merged

Conversation

nolouch
Copy link
Contributor

@nolouch nolouch commented Mar 24, 2021

What problem does this PR solve?

ref #3521
the problem is when offline a store, we may add learner multiple times if the operator is timeout.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)

Related changes

Release note

@ti-chi-bot ti-chi-bot requested review from disksing and lhy1024 March 24, 2021 14:22
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 24, 2021
@disksing
Copy link
Contributor

need any test?

@disksing
Copy link
Contributor

basically LGTM except for lack of tests.

Signed-off-by: nolouch <nolouch@gmail.com>
@nolouch
Copy link
Contributor Author

nolouch commented Mar 25, 2021

PTAL @disksing @HunDunDM

Signed-off-by: nolouch <nolouch@gmail.com>
@nolouch nolouch added needs-cherry-pick-release-4.0 The PR needs to cherry pick to release-4.0 branch. needs-cherry-pick-release-5.0 The PR needs to cherry pick to release-5.0 branch. labels Mar 25, 2021
@codecov
Copy link

codecov bot commented Mar 25, 2021

Codecov Report

Merging #3522 (24b9b7b) into master (c4f22fd) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3522      +/-   ##
==========================================
+ Coverage   74.56%   74.61%   +0.04%     
==========================================
  Files         245      245              
  Lines       24068    24068              
==========================================
+ Hits        17947    17958      +11     
+ Misses       4509     4504       -5     
+ Partials     1612     1606       -6     
Flag Coverage Δ
unittests 74.61% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/schedule/checker/rule_checker.go 80.00% <100.00%> (-0.72%) ⬇️
server/schedulers/shuffle_hot_region.go 54.73% <0.00%> (-9.48%) ⬇️
server/tso/global_allocator.go 70.80% <0.00%> (-6.57%) ⬇️
server/id/id.go 76.19% <0.00%> (-4.77%) ⬇️
server/tso/local_allocator.go 80.28% <0.00%> (-2.82%) ⬇️
client/base_client.go 83.24% <0.00%> (-2.17%) ⬇️
pkg/btree/btree.go 85.30% <0.00%> (-0.97%) ⬇️
server/server.go 71.98% <0.00%> (ø)
client/client.go 72.24% <0.00%> (+0.13%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4f22fd...24b9b7b. Read the comment docs.

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HunDunDM
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 25, 2021
@nolouch
Copy link
Contributor Author

nolouch commented Mar 25, 2021

/merge

@ti-chi-bot
Copy link
Member

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4737707

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 25, 2021
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
4.2% 4.2% Duplication

@nolouch
Copy link
Contributor Author

nolouch commented Mar 25, 2021

/build

@ti-chi-bot ti-chi-bot merged commit 60508bd into tikv:master Mar 25, 2021
ti-srebot pushed a commit to ti-srebot/pd that referenced this pull request Mar 25, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #3529

ti-srebot pushed a commit to ti-srebot/pd that referenced this pull request Mar 25, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #3530

ti-chi-bot pushed a commit that referenced this pull request Mar 25, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: ShuNing <nolouch@gmail.com>
ti-chi-bot added a commit that referenced this pull request May 10, 2021
* cherry pick #3522 to release-4.0

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

* fix

Signed-off-by: nolouch <nolouch@gmail.com>

Co-authored-by: ShuNing <nolouch@gmail.com>
Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
@nolouch nolouch deleted the up-priority branch June 21, 2021 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-4.0 The PR needs to cherry pick to release-4.0 branch. needs-cherry-pick-release-5.0 The PR needs to cherry pick to release-5.0 branch. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants