-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server: make leader can lost lease as soon as possible (#3712) #3718
server: make leader can lost lease as soon as possible (#3712) #3718
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot: This cherry pick PR is for a release branch and has not yet been approved by release team. To merge this cherry pick, it must first be approved ( AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@nolouch Please fix the conflicts |
Signed-off-by: nolouch <nolouch@gmail.com>
Signed-off-by: nolouch <nolouch@gmail.com>
65a7726
to
e298cd9
Compare
Signed-off-by: nolouch <nolouch@gmail.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## release-4.0 #3718 +/- ##
===============================================
+ Coverage 74.72% 75.11% +0.38%
===============================================
Files 211 211
Lines 19940 19952 +12
===============================================
+ Hits 14901 14987 +86
+ Misses 3701 3623 -78
- Partials 1338 1342 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/merge |
@nolouch: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 03b5127
|
This is an automated cherry-pick of #3712
Signed-off-by: nolouch nolouch@gmail.com
What problem does this PR solve?
Fix #3697
When the store's number is 180. we resign pd leader may need one minute or more to finish elect the new leader:
details replay: https://gist.github.com/disksing/a1bf78007b674da7e15b52a9e25eb3a5
What is changed and how it works?
make leader can be lost lease as soon as possible
Check List
Tests
Release note