-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pd-ctl: try to fix interactive mode (#3782) #3784
pd-ctl: try to fix interactive mode (#3782) #3784
Conversation
Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
Codecov Report
@@ Coverage Diff @@
## release-5.1 #3784 +/- ##
===============================================
- Coverage 75.08% 74.89% -0.19%
===============================================
Files 245 245
Lines 24531 24540 +9
===============================================
- Hits 18418 18380 -38
- Misses 4493 4526 +33
- Partials 1620 1634 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/merge |
@nolouch: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
@nolouch: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
@nolouch: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 356559b
|
This is an automated cherry-pick of #3782
What problem does this PR solve?
Seems cobra command does not support interactive mode, that is we need to init a new command every new line in the REPL.
What is changed and how it works?
readlineCompleter
global variables are removed, it is now inlined and created-as-need.PersistentFlags
from the root command will be inherited in the REPL, pd address for example.Check List
Tests
Interactive should print normally, and show connection refused on port 34.
Release note